-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sys/stdio_ethos: replace USE_ETHOS_FOR_STDIO by stdio_ethos pseudomodule #11668
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to have it implemented without #11598 as this one could be done by adding stdio_uart_rx
dependency alone.
Some minor remarks inline.
Further steps for other pull requests.
From the implementation, it looks like stdio_ethos
should be moved to its own module like stdio_rtt
. But it is another task that requires many changes.
Also the code is doing implicit circular dependency, the code in drivers/ethos
for stdio references variables defined in stdio_uart
…
drivers/ethos/ethos.c:extern isrpipe_t stdio_uart_isrpipe;
Once #11598 is merged (and I hope it will be soon), there will be no need to rework this one. Let's finish #11598, which will fix #11525 btw, and continue improving other things afterwards. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost good to go. Please add the missing "stdio_uart" dependency.
please rebase |
5c3555a
to
2859849
Compare
Please squash! |
d53c85b
to
5e2f267
Compare
squashed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK.
I found another reference of USE_ETHOS_STDIO in ethos' own README.md and pushed a commit that updates it.
Please take a quick look.
Otherwise I tested that gnrc_border_router still works using make term
.
Comments have been addressed, reviewer on holidays. Thx @cladmi!
Looks good. Thanks! |
Contribution description
This PR provides a new module
stdio_ethos
as a replacement forUSE_ETHOS_FOR_STDIO
. Applications using this macro now depends on this new module.stdio_ethos
also depends on the ethos and stdin, provided in #11598.Testing procedure
examples/gnrc_border_router
should still workstdio_ethos
:tests/riotboot_flashwrite
,tests/gnrc_ipv6_ext
,tests/gnrc_rpl_srh
andtests/gnrc_sock_dns
.Issues/PRs references
Based on #11598