Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make: fix rebuilding on changes without clean or -B #1198

Merged
merged 1 commit into from
May 16, 2014
Merged

make: fix rebuilding on changes without clean or -B #1198

merged 1 commit into from
May 16, 2014

Conversation

Kijewski
Copy link
Contributor

Partial revert of 85b7eca

Fixes #1197.

@Kijewski
make: fix #1197
66a3d7d 
Partial revert of 85b7eca

Fixes #1197.
@Kijewski Kijewski added this to the Release 2014.05 milestone May 16, 2014
@Kijewski
Copy link
Contributor Author

We'd need to replace almost every instance of all in the make system with $(ELFFILE) to make the previous idea running. That's not that bad, but we should still use this quick fix until someone digs deeper into that matter.

Pocking @authmillenon.

@OlegHahm
Copy link
Member

You wanna challenge @LudwigOrtmann for the worst title of a PR? Point from my side: cannot tell what this about without clicking a further link.

@Kijewski
Copy link
Contributor Author

So I win? This is good, isn't it? :P

(title changed)

@Kijewski Kijewski changed the title make: fix #1197 make: fix rebuilding on changes without clean or -B May 16, 2014
@LudwigKnuepfer
Copy link
Member

Oh, I didn't see to get the original title AND I can't remember my worst title.

@LudwigKnuepfer
Copy link
Member

=(

@Kijewski
Copy link
Contributor Author

So, are you gonna review this PR?

This was referenced May 16, 2014
Closed
Closed
@LudwigKnuepfer
Copy link
Member

Yes, I'm gonna.

@LudwigKnuepfer
Copy link
Member

Seems to work

@LudwigKnuepfer
Copy link
Member

So I ACK

@miri64
Copy link
Member

miri64 commented May 16, 2014

ACK, status I tried to fix in #1195 is working again.

miri64 added a commit that referenced this pull request May 16, 2014
@miri64
Merge pull request #1198 from Kijewski/issue-1197
f8e329b 
make: fix rebuilding on changes without `clean` or `-B`
@miri64 miri64 merged commit f8e329b into RIOT-OS:master May 16, 2014
@miri64
Copy link
Member

miri64 commented May 16, 2014

\o/ https://ci.riot-os.org/jenkins/job/RIOT-native-unittests-clang/ und https://ci.riot-os.org/jenkins/job/RIOT-native-unittests-gcc/

@Kijewski Kijewski deleted the issue-1197 branch May 16, 2014 20:32
This was referenced Mar 27, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@LudwigKnuepfer LudwigKnuepfer

Labels
Area: build system Area: Build system Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2014.05
Development

Successfully merging this pull request may close these issues.

make: make all does not rebuild anymore if source has changed
4 participants
@Kijewski @OlegHahm @LudwigKnuepfer @miri64