Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys/usbus: Expose configurations to Kconfig #13374

Merged
merged 3 commits into from
Apr 3, 2020
Merged

sys/usbus: Expose configurations to Kconfig #13374

merged 3 commits into from
Apr 3, 2020

Conversation

leandrolanzieri
Copy link
Contributor

Contribution description

This moves USBUS_AUTO_ATTACH and USBUS_EP0_SIZE configuration options to the CONFIG_ namespace, and exposes them to Kconfig.

Testing procedure

Test with examples/usbus_minimal: Should work normally and you should be able to change options via Kconfig.

Issues/PRs references

Part of #12888

@leandrolanzieri leandrolanzieri added Type: new feature The issue requests / The PR implemements a new feature for RIOT Area: Kconfig Area: Kconfig integration labels Feb 13, 2020
@leandrolanzieri leandrolanzieri added this to the Release 2020.04 milestone Feb 13, 2020
This was referenced Feb 13, 2020
Open
Merged
@tcschmidt
Copy link
Member

@cgundogan @bergzand what about this: can we push for the release?

bergzand
bergzand reviewed Apr 3, 2020
View reviewed changes
sys/usb/usbus/Kconfig Outdated Show resolved Hide resolved
@bergzand
Copy link
Member

bergzand commented Apr 3, 2020

The config options look good to me. I've played around with the configuration options and things look fine. I've asked @cgundogan to give this a final test.

cgundogan
cgundogan approved these changes Apr 3, 2020
View reviewed changes
Copy link
Member

@cgundogan cgundogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verify that the changes I do in the kconfig menu end up correctly in the configuration file and that they are picked up correctly when compiling. I can also see the newly introduced "choice" feature for USBUS_EP0_SIZE. ACK!

@dylad dylad added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Apr 3, 2020
@cgundogan cgundogan added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels Apr 3, 2020
@leandrolanzieri leandrolanzieri force-pushed the pr/kconfig_migrate/sys/usbus branch from ce38414 to 06920a1 Compare April 3, 2020 12:45
@cgundogan cgundogan merged commit fca7548 into RIOT-OS:master Apr 3, 2020
@leandrolanzieri
Copy link
Contributor Author

Thanks everyone for reviewing and testing!

@leandrolanzieri leandrolanzieri deleted the pr/kconfig_migrate/sys/usbus branch April 3, 2020 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergzand bergzand bergzand left review comments

@cgundogan cgundogan cgundogan approved these changes

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@dylad dylad Awaiting requested review from dylad dylad is a code owner

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

Assignees
No one assigned
Labels
Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Milestone
Release 2020.04
Development

Successfully merging this pull request may close these issues.
5 participants
@leandrolanzieri @tcschmidt @bergzand @cgundogan @dylad