gnrc/rpl: Expose configurations to Kconfig #13941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leandrolanzieri
added
Area: network
leandrolanzieri
requested review from
haukepetersen,
jia200x and
PeterKietzmann
as code owners
71 tasks
leandrolanzieri
force-pushed
the
pr/kconfig_migrate/net/gnrc/rpl
branch
from
90ca355 to
06e7932
Compare
|
@leandrolanzieri code-wise the changes look correct. I wanted to give this a test, but the RPL menu does not appear in the menu? Is an include missing? |
cgundogan
added
Reviewed: 1-fundamentals
Indeed, please give it a try now :-) |
cgundogan
approved these changes
May 14, 2020
|
and please squash. |
Also evaluate its value using IS_ACTIVE when possible.
Also check its value using IS_ACTIVE when possible.
leandrolanzieri
force-pushed
the
pr/kconfig_migrate/net/gnrc/rpl
branch
from
61184a9 to
4b3bfd3
Compare
|
Done |
cgundogan
added
Reviewed: 3-testing
miri64
reviewed
May 14, 2020
| #ifndef GNRC_RPL_MSG_QUEUE_SIZE | ||
| #define GNRC_RPL_MSG_QUEUE_SIZE (8U) | ||
| #ifndef CONFIG_GNRC_RPL_MSG_QUEUE_SIZE | ||
| #define CONFIG_GNRC_RPL_MSG_QUEUE_SIZE (8U) |
There was a problem hiding this comment.
In #14071 the exponent was used to model the power of 2 restriction of message queues. Should we do this here as well or rather as a follow-up (including the other queue sizes)
There was a problem hiding this comment.
Good point. Let's defer that to a follow-up PR, though. The diff and commit history is already kind of convoluted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR moves configuration macros of GNRC RPL module to
CONFIG_namespace and exposes them to Kconfig.Testing procedure
menuconfig) should reflect on the configuration macros.Issues/PRs references
Part of #12888