Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers/isl29020 : Expose Configurations to Kconfig #13995

Merged
merged 3 commits into from
May 8, 2020
Merged

drivers/isl29020 : Expose Configurations to Kconfig #13995

merged 3 commits into from
May 8, 2020

Conversation

akshaim
Copy link
Member

@akshaim akshaim commented May 1, 2020

Contribution description

This PR exposes compile configurations in ISL29020 Sensor Device driver to Kconfig.

Testing procedure

  1. New documentation was built using doxygen

The build worked fine.

  1. New macro was introduced in tests/driver_tmp00x/main.c for testing.
#define STR(x)   #x
#define SHOW_DEFINE(x) printf("%s=%s\n", #x, STR(x))

Firmware was uploaded to FIT IoT Lab test bed.

Default State:

Firmware Output

main(): This is RIOT! (Version: 2020.07-devel-311-gec19c-Kconfig_isl29020_tests)
CONFIG_ISL29020_DEFAULT_ADDRESS=0x44
ISL29020 light sensor test application

Initializing ISL29020 sensor
[Failed]

Usage with CFLAGS

/tests/driver_isl29020/Makefile

CFLAGS += -DCONFIG_ISL29020_DEFAULT_ADDRESS=0x45

Firmware Output

main(): This is RIOT! (Version: 2020.07-devel-311-gec19c-Kconfig_isl29020_tests)
CONFIG_ISL29020_DEFAULT_ADDRESS=0x45
ISL29020 light sensor test application

Initializing ISL29020 sensor
[Failed]

Usage with Kconfig

/tests/driver_isl29020/

make menuconfig

Firmware Output

main(): This is RIOT! (Version: 2020.07-devel-312-gc0d85b-Kconfig_isl29020_tests)
CONFIG_ISL29020_DEFAULT_ADDRESS=0x45
ISL29020 light sensor test application

Initializing ISL29020 sensor
[Failed]

Note : The sensor is not available for interfacing hence configurability of macros were only tested.

Issues/PRs references

#12888
@leandrolanzieri Please merge this only after #13981

@leandrolanzieri leandrolanzieri added Area: Kconfig Area: Kconfig integration Area: drivers Area: Device drivers Type: new feature The issue requests / The PR implemements a new feature for RIOT labels May 4, 2020
@leandrolanzieri leandrolanzieri added this to the Release 2020.07 milestone May 4, 2020
@leandrolanzieri leandrolanzieri added the State: waiting for other PR State: The PR requires another PR to be merged first label May 4, 2020
@leandrolanzieri leandrolanzieri mentioned this pull request May 4, 2020
Open
71 tasks
@leandrolanzieri leandrolanzieri removed the State: waiting for other PR State: The PR requires another PR to be merged first label May 4, 2020
@leandrolanzieri
Copy link
Contributor

Please rebase

@akshaim akshaim force-pushed the Kconfig_isl29020 branch from 631dab8 to 070849d Compare May 4, 2020 12:05
@akshaim
Copy link
Member Author

akshaim commented May 4, 2020

Please rebase

Done.

@akshaim akshaim force-pushed the Kconfig_isl29020 branch from 070849d to f15ef7a Compare May 4, 2020 12:40
leandrolanzieri
leandrolanzieri reviewed May 7, 2020
View reviewed changes
Copy link
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small comment, otherwise it looks good. Squash directly.

drivers/include/isl29020.h Outdated Show resolved Hide resolved
@leandrolanzieri
Copy link
Contributor

@akshaim please squash and rebase

@akshaim akshaim force-pushed the Kconfig_isl29020 branch from dea4f37 to e207488 Compare May 8, 2020 12:32
@akshaim
Copy link
Member Author

akshaim commented May 8, 2020

@akshaim please squash and rebase

Done. Thanks for the review

akshaim added 3 commits May 8, 2020 18:07
@akshaim
drivers/isl29020 : Add CONFIG_
38687e6 
Add CONFIG_ prefix to ISL29020_DEFAULT_ADDRESS
@akshaim
drivers/isl29020 : Make ADDR configurable
f01bbd3 
Make ISL29020_PARAM_ADDR configurable
@akshaim
drivers/isl29020 : Expose to Kconfig
db96ebc 
Expose configurations to Kconfig.
@akshaim akshaim force-pushed the Kconfig_isl29020 branch from e207488 to db96ebc Compare May 8, 2020 12:37
leandrolanzieri
leandrolanzieri approved these changes May 8, 2020
View reviewed changes
Copy link
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. ACK.

@leandrolanzieri leandrolanzieri added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels May 8, 2020
@leandrolanzieri leandrolanzieri merged commit bf9cfb1 into RIOT-OS:master May 8, 2020
@akshaim akshaim deleted the Kconfig_isl29020 branch June 3, 2020 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leandrolanzieri leandrolanzieri leandrolanzieri approved these changes

@cgundogan cgundogan Awaiting requested review from cgundogan

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

Assignees
No one assigned
Labels
Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Milestone
Release 2020.07
Development

Successfully merging this pull request may close these issues.
2 participants
@akshaim @leandrolanzieri