Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers/lpsxxx : Expose Configurations to Kconfig #14000

Merged
merged 2 commits into from
May 5, 2020
Merged

drivers/lpsxxx : Expose Configurations to Kconfig #14000

merged 2 commits into from
May 5, 2020

Conversation

akshaim
Copy link
Member

@akshaim akshaim commented May 1, 2020

Contribution description

This PR exposes compile configurations in LPS331AP/LPS25HB/LPS22HB Sensor Device driver to Kconfig.

Testing procedure

  1. New documentation was built using doxygen

The build works fine.

  1. New macro was introduced in tests/driver_tmp00x/main.c for testing.
#define STR(x)   #x
#define SHOW_DEFINE(x) printf("%s=%s\n", #x, STR(x))

Firmware was uploaded to FIT IoT Lab test bed.

Default State:

Firmware Output

main(): This is RIOT! (Version: 2020.07-devel-310-g88d0b-Kconfig_lpsxxx_tests)
CONFIG_LPSXXX_DEFAULT_ADDRESS=(0x5d)
Test application for lps331ap pressure sensor

Initializing lps331ap sensor
Initialization failed

Usage with CFLAGS

/tests/driver_lpsxxx/Makefile

CFLAGS += -DCONFIG_LPSXXX_DEFAULT_ADDRESS=0x5c

Firmware OutputLPS331AP/LPS25HB/LPS22HB

main(): This is RIOT! (Version: 2020.07-devel-310-g88d0b-Kconfig_lpsxxx_tests)
CONFIG_LPSXXX_DEFAULT_ADDRESS=0x5c
Test application for lps331ap pressure sensor

Initializing lps331ap sensor
Initialization failed

Usage with Kconfig

/tests/driver_lpsxxx/

make menuconfig

Firmware Output

main(): This is RIOT! (Version: 2020.07-devel-310-g88d0b-Kconfig_lpsxxx_tests)
CONFIG_LPSXXX_DEFAULT_ADDRESS=0x5c
Test application for lps331ap pressure sensor

Initializing lps331ap sensor
Initialization failed

Note : The sensor is not available for interfacing hence configurability of macros were only tested.

Issues/PRs references

#12888
@leandrolanzieri Please merge this only after #13981

@leandrolanzieri leandrolanzieri added Area: Kconfig Area: Kconfig integration Area: drivers Area: Device drivers Type: new feature The issue requests / The PR implemements a new feature for RIOT labels May 4, 2020
@leandrolanzieri leandrolanzieri added this to the Release 2020.07 milestone May 4, 2020
@leandrolanzieri leandrolanzieri added State: waiting for other PR State: The PR requires another PR to be merged first and removed State: waiting for other PR State: The PR requires another PR to be merged first labels May 4, 2020
@leandrolanzieri
Copy link
Contributor

Please rebase

@akshaim
drivers/lpsxxx : Add CONFIG_
db7ca7e 
Add CONFIG_ prefix to LPSXXX_DEFAULT_ADDRESS
@akshaim
Copy link
Member Author

akshaim commented May 4, 2020

Please rebase

Done

@akshaim
drivers/lpsxxx : Expose to Kconfig
a084383 
Expose configurations to Kconfig and update documentation.
leandrolanzieri
leandrolanzieri approved these changes May 4, 2020
View reviewed changes
Copy link
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Changing the address on menuconfig results in the macro correctly set. Also the current default stays the same. ACK.

@leandrolanzieri leandrolanzieri added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels May 4, 2020
@leandrolanzieri leandrolanzieri merged commit 28eedd6 into RIOT-OS:master May 5, 2020
@leandrolanzieri leandrolanzieri mentioned this pull request May 5, 2020
Open
71 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leandrolanzieri leandrolanzieri leandrolanzieri approved these changes

@cgundogan cgundogan Awaiting requested review from cgundogan

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

Assignees
No one assigned
Labels
Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Milestone
Release 2020.07
Development

Successfully merging this pull request may close these issues.
2 participants
@akshaim @leandrolanzieri