gnrc/pktbuf : Expose Configurations to Kconfig #14056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshaim
requested review from
aabadie,
cgundogan,
fjmolinas,
gschorcht,
haukepetersen,
jia200x,
kaspar030,
leandrolanzieri,
MichelRottleuthner,
miri64,
PeterKietzmann and
smlng
as code owners
leandrolanzieri
added
Area: Kconfig
miri64
reviewed
May 12, 2020
71 tasks
|
This needs rebasing |
leandrolanzieri
previously requested changes
May 28, 2020
Done |
|
It seems you are missing one macro rename Line 37 in daae5a1 |
Done. Added guards as well. |
|
Looks good. Please squash |
akshaim
force-pushed
the
Kconfig_pktbuf
branch
2 times, most recently
from
f9b0362 to
f4af1f2
Compare
miri64
approved these changes
Jun 8, 2020
miri64
added
the
CI: ready for build
|
This needs rebasing |
Add compile configuration 'GNRC_PKTBUF_SIZE' to 'net_gnrc_conf' group
Expose CONF_GNRC_PKTBUF_SIZE to Kconfig
Set Kconfig defaults for CPU and conditions to avoid conflict with CFLAGS Co-authored-by: Leandro Lanzieri <[email protected]>
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR exposes compile configurations in PKTBUF GNRC to Kconfig.
Testing procedure
The build works fine.
Test Files
Default State:
Firmware Output
Default
RIOT native interrupts/signals initialized.
LED_RED_OFF
LED_GREEN_ON
RIOT native board initialized.
RIOT native hardware initialization complete.
main(): This is RIOT! (Version: 2020.07-devel-507-g579f7-Kconfig_tests)
CONF_GNRC_PKTBUF_SIZE=(6144)
Usage with CFLAGS
/tests/gnrc_pktbuf/Makefile
Firmware Output
RIOT native interrupts/signals initialized.
LED_RED_OFF
LED_GREEN_ON
RIOT native board initialized.
RIOT native hardware initialization complete.
main(): This is RIOT! (Version: 2020.07-devel-507-g579f7-Kconfig_tests)
CONF_GNRC_PKTBUF_SIZE=5000
Usage with Kconfig
/tests/gnrc_pktbuf
Firmware Output
RIOT native interrupts/signals initialized.
LED_RED_OFF
LED_GREEN_ON
RIOT native board initialized.
RIOT native hardware initialization complete.
main(): This is RIOT! (Version: 2020.07-devel-507-g579f7-Kconfig_tests)
CONF_GNRC_PKTBUF_SIZE=8000
Issues/PRs references
#12888
@leandrolanzieri