Makefile: add BINFILE to default BUILD_FILES #14159
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR adds
BINFILE
to defaultBUILDFILES
, I did not do that in CI, because I saw that it increased build time a bit, see testing results.I did this because iot-lab now uses the
BINFILE
to flash, and this did not work if I use flash-only on a command previously compiled without anyIOTLAB_%
environment variable, see testing procedure.This only happens if
iotlabcli>3
is installed since before the elffile was used.Testing procedure
BOARD=iotlab-m3 make -C examples/hello-world/ all
IOTLAB_NODE=m3-1.saclay.iot-lab.info BOARD=iotlab-m3 make -C examples/hello-world/ flash-only --no-print-directory
iotlab-node --jmespath='keys(@)[0]' --format='int' --list saclay,m3,1 --update /home/francisco/workspace/RIOT/examples/hello-world/bin/iotlab-m3/hello-world.elf | grep 0
0
Build Time
BINFILE