Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kconfig/armv7_m/cortexm: declare CPU_ARCH and CPU_CORE symbols #14162

Merged
merged 1 commit into from
May 28, 2020
Merged

Kconfig/armv7_m/cortexm: declare CPU_ARCH and CPU_CORE symbols #14162

merged 1 commit into from
May 28, 2020

Conversation

jia200x
Copy link
Member

@jia200x jia200x commented May 28, 2020 •
edited
Loading

Contribution description

This PR declares the armvx_m architectures and the cortex-m cores in Kconfig. This step is required for #14148

Testing procedure

  • Check that Kconfig executes with no errors
  • Check if exposed symbols match the ones in RIOT

Issues/PRs references

#14148

@jia200x jia200x added the Area: Kconfig Area: Kconfig integration label May 28, 2020
@jia200x jia200x requested a review from leandrolanzieri May 28, 2020 10:12
@jia200x jia200x requested a review from cgundogan as a code owner May 28, 2020 10:12
@jia200x jia200x changed the title Kconfig/arm7/cortexm: declare CPU_ARCH and CPU_CORE symbols Kconfig/armv7_m/cortexm: declare CPU_ARCH and CPU_CORE symbols May 28, 2020
@jia200x jia200x force-pushed the pr/kconfig/cortex branch from 9256d58 to c19e618 Compare May 28, 2020 10:26
@jia200x jia200x force-pushed the pr/kconfig/cortex branch 3 times, most recently from 2f00c16 to 69cfff8 Compare May 28, 2020 11:51
@leandrolanzieri leandrolanzieri added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label May 28, 2020
@leandrolanzieri @jia200x
cpu/cortexm_common: Add Kconfig symbols
be8289b 
This declares the architecture and core specific Kconfig symbols and the
features provided by it are selected.
@jia200x jia200x force-pushed the pr/kconfig/cortex branch from 69cfff8 to be8289b Compare May 28, 2020 12:11
cgundogan
cgundogan reviewed May 28, 2020
View reviewed changes
Copy link
Member

@cgundogan cgundogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sensible modeling of the basic features and symbols. Addition is also unintrusive.

@cgundogan cgundogan added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels May 28, 2020
@leandrolanzieri leandrolanzieri added the Reviewed: 3-testing The PR was tested according to the maintainer guidelines label May 28, 2020
@jia200x jia200x merged commit 917cc66 into RIOT-OS:master May 28, 2020
@leandrolanzieri leandrolanzieri mentioned this pull request May 28, 2020
Merged
@leandrolanzieri leandrolanzieri added this to the Release 2020.07 milestone Jun 5, 2020
@miri64 miri64 added the Type: new feature The issue requests / The PR implemements a new feature for RIOT label Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgundogan cgundogan cgundogan approved these changes

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

Assignees
No one assigned
Labels
Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Milestone
Release 2020.07
Development

Successfully merging this pull request may close these issues.
4 participants
@jia200x @cgundogan @miri64 @leandrolanzieri