-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boards/samd21-based: Model features in Kconfig #14189
Conversation
This needs rebasing |
This needs rebasing and adapting to the new classification |
@jia200x ping! |
56018ba
to
1114b32
Compare
@jia200x will not be having time so he said it's ok to take over. I rebased and applied some fixes. @fjmolinas maybe you can take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one minor nit. Please rebase!
3ec1798
to
47be8b1
Compare
Rebased once more :) |
47be8b1
to
1abe732
Compare
Same here, I was also on it :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good, ACK!
Contribution description
This PR models the features for samd21 based boards and adds them to the
Kconfig_features
test whitelist.Testing procedure
It should be enough to check that the
Kconfig_features
test works for all these boards (this means the list of provided features is equivalent):Issues/PRs references
Depends on #13404#14148