Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards/samd21-based: Model features in Kconfig #14189

Merged
merged 33 commits into from
Jul 17, 2020

Conversation

jia200x
Copy link
Member

@jia200x jia200x commented Jun 2, 2020

Contribution description

This PR models the features for samd21 based boards and adds them to the Kconfig_features test whitelist.

Testing procedure

It should be enough to check that the Kconfig_features test works for all these boards (this means the list of provided features is equivalent):

BOARD=arduino-mkr1000 make && \
BOARD=arduino-mkrfox1200 make && \
BOARD=arduino-mkrwan1300 make && \
BOARD=arduino-mkrzero make && \
BOARD=arduino-zero make && \
BOARD=feather-m0 make && \
BOARD=hamilton make && \
BOARD=samd21-xpro make && \
BOARD=samr21-xpro make && \
BOARD=sensebox_samd21 make && \
BOARD=serpente make && \
BOARD=sodaq-autonomo make && \
BOARD=sodaq-explorer make && \
BOARD=sodaq-one make && \
BOARD=sodaq-sara-aff &&\
echo "OK"

Issues/PRs references

Depends on #13404
#14148

@jia200x jia200x added Type: new feature The issue requests / The PR implemements a new feature for RIOT TF: Config Marks issues and PRs related to the work of the Configuration Task Force Area: Kconfig Area: Kconfig integration labels Jun 2, 2020
boards/arduino-mkr1000/Kconfig Outdated Show resolved Hide resolved
boards/arduino-mkr1000/Kconfig Outdated Show resolved Hide resolved
boards/sodaq-autonomo/Kconfig Outdated Show resolved Hide resolved
@jia200x jia200x force-pushed the pr/boards/samd21 branch from 8b5b747 to a9ccca9 Compare June 2, 2020 14:03
@jia200x jia200x changed the title boards/samd21: Model features in Kconfig boards/samd21-based: Model features in Kconfig Jun 2, 2020
@leandrolanzieri leandrolanzieri added the State: waiting for other PR State: The PR requires another PR to be merged first label Jun 2, 2020
@leandrolanzieri
Copy link
Contributor

This needs rebasing

@jia200x jia200x force-pushed the pr/boards/samd21 branch from 03b8d20 to 56018ba Compare June 3, 2020 08:30
@leandrolanzieri leandrolanzieri added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed State: waiting for other PR State: The PR requires another PR to be merged first CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jun 3, 2020
@leandrolanzieri leandrolanzieri removed the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jun 4, 2020
@leandrolanzieri
Copy link
Contributor

This needs rebasing and adapting to the new classification

@leandrolanzieri
Copy link
Contributor

@jia200x ping!

@leandrolanzieri
Copy link
Contributor

@jia200x will not be having time so he said it's ok to take over. I rebased and applied some fixes.

@fjmolinas maybe you can take a look?

@leandrolanzieri leandrolanzieri self-assigned this Jul 9, 2020
Copy link
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one minor nit. Please rebase!

boards/sodaq-autonomo/Kconfig Outdated Show resolved Hide resolved
@leandrolanzieri
Copy link
Contributor

Rebased once more :)

@aabadie aabadie force-pushed the pr/boards/samd21 branch from 47be8b1 to 1abe732 Compare July 17, 2020 06:48
@aabadie aabadie added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jul 17, 2020
@aabadie
Copy link
Contributor

aabadie commented Jul 17, 2020

Rebased once more :)

Same here, I was also on it :)

Copy link
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, ACK!

@aabadie aabadie merged commit 00f28a3 into RIOT-OS:master Jul 17, 2020
@leandrolanzieri leandrolanzieri added this to the Release 2020.10 milestone Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR TF: Config Marks issues and PRs related to the work of the Configuration Task Force Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants