Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards/arduino-leonardo: Model features in Kconfig #14195

Merged
merged 3 commits into from
Jun 23, 2020
Merged

boards/arduino-leonardo: Model features in Kconfig #14195

merged 3 commits into from
Jun 23, 2020

Conversation

leandrolanzieri
Copy link
Contributor

@leandrolanzieri leandrolanzieri commented Jun 3, 2020 •
edited
Loading

Contribution description

This PR models the symbols for the atmega32u4 CPU and the arduino-leonardo board (which is the only one so far that uses it).

The first 2 commits are from #14176, they are included for testing.

Testing procedure

  • tests/kconfig_features should pass for the arduino-leonardo

Issues/PRs references

Depends on #14176

@leandrolanzieri leandrolanzieri added Type: new feature The issue requests / The PR implemements a new feature for RIOT Area: Kconfig Area: Kconfig integration labels Jun 3, 2020
@jia200x jia200x mentioned this pull request Jun 3, 2020
Closed
@leandrolanzieri leandrolanzieri added the State: waiting for other PR State: The PR requires another PR to be merged first label Jun 3, 2020
@leandrolanzieri leandrolanzieri force-pushed the pr/kconfig/atmega32u4_boards_symbols branch from 56df85e to 1d278de Compare June 23, 2020 07:58
@leandrolanzieri leandrolanzieri removed the State: waiting for other PR State: The PR requires another PR to be merged first label Jun 23, 2020
@leandrolanzieri
Copy link
Contributor Author

Rebased and adapted to the current classification.

@fjmolinas fjmolinas added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jun 23, 2020
fjmolinas
fjmolinas approved these changes Jun 23, 2020
View reviewed changes
Copy link
Contributor

@fjmolinas fjmolinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Symbols makes sense and test pases, ACK

BOARD=arduino-leonardo make -C tests/kconfig_features/ clean all
SUCCESS: BOARD values match
SUCCESS: CPU values match

@fjmolinas fjmolinas self-assigned this Jun 23, 2020
@leandrolanzieri leandrolanzieri mentioned this pull request Jun 23, 2020
Merged
@leandrolanzieri leandrolanzieri added this to the Release 2020.07 milestone Jun 23, 2020
@fjmolinas
Copy link
Contributor

GO!

@fjmolinas fjmolinas merged commit f630669 into RIOT-OS:master Jun 23, 2020
@leandrolanzieri leandrolanzieri deleted the pr/kconfig/atmega32u4_boards_symbols branch June 23, 2020 12:09
@leandrolanzieri
Copy link
Contributor Author

Thanks for reviewing and testing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjmolinas fjmolinas fjmolinas approved these changes

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@maribu maribu Awaiting requested review from maribu

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@cgundogan cgundogan Awaiting requested review from cgundogan

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@smlng smlng Awaiting requested review from smlng

Assignees

@fjmolinas fjmolinas

Labels
Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Milestone
Release 2020.07
Development

Successfully merging this pull request may close these issues.
2 participants
@leandrolanzieri @fjmolinas