Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards/atmega128rfa1-based: Model features in Kconfig #14203

Merged
merged 5 commits into from
Jun 22, 2020
Merged

boards/atmega128rfa1-based: Model features in Kconfig #14203

merged 5 commits into from
Jun 22, 2020

Conversation

leandrolanzieri
Copy link
Contributor

@leandrolanzieri leandrolanzieri commented Jun 4, 2020 •
edited
Loading

Contribution description

This models the features in Kconfig for all the boards based on the atmega128rfa1 CPU.
The first 2 commits are from #14176, they are included for testing.

Testing procedure

  • tests/kconfig_features should pass for:
    • derfmega128
    • microduino-corerf

Issues/PRs references

Depends on #14176

@leandrolanzieri leandrolanzieri added Type: new feature The issue requests / The PR implemements a new feature for RIOT Platform: AVR Platform: This PR/issue effects AVR-based platforms Area: Kconfig Area: Kconfig integration labels Jun 4, 2020
@leandrolanzieri leandrolanzieri force-pushed the pr/kconfig/atmega128rfa1_boards_symbols branch from 221c0fc to ff945c3 Compare June 4, 2020 12:36
@leandrolanzieri leandrolanzieri added the State: waiting for other PR State: The PR requires another PR to be merged first label Jun 4, 2020
@jia200x jia200x mentioned this pull request Jun 4, 2020
Closed
@leandrolanzieri leandrolanzieri force-pushed the pr/kconfig/atmega128rfa1_boards_symbols branch from ff945c3 to e7df68c Compare June 17, 2020 11:35
@leandrolanzieri leandrolanzieri removed the State: waiting for other PR State: The PR requires another PR to be merged first label Jun 17, 2020
@leandrolanzieri leandrolanzieri force-pushed the pr/kconfig/atmega128rfa1_boards_symbols branch from e7df68c to d0a368d Compare June 22, 2020 13:20
PeterKietzmann
PeterKietzmann requested changes Jun 22, 2020
View reviewed changes
Copy link
Member

@PeterKietzmann PeterKietzmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a minor comment, ACK otherwise. Changes look valid and tests/kconfig_features passes for both boards.

cpu/atmega128rfa1/Kconfig Outdated Show resolved Hide resolved
PeterKietzmann
PeterKietzmann approved these changes Jun 22, 2020
View reviewed changes
Copy link
Member

@PeterKietzmann PeterKietzmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK please squash

@PeterKietzmann PeterKietzmann added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels Jun 22, 2020
@leandrolanzieri leandrolanzieri force-pushed the pr/kconfig/atmega128rfa1_boards_symbols branch from 18faff3 to 8f8bcda Compare June 22, 2020 14:10
@leandrolanzieri
Copy link
Contributor Author

Squashed

@PeterKietzmann PeterKietzmann added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jun 22, 2020
@leandrolanzieri leandrolanzieri added this to the Release 2020.07 milestone Jun 22, 2020
@PeterKietzmann PeterKietzmann merged commit cf27fda into RIOT-OS:master Jun 22, 2020
@leandrolanzieri leandrolanzieri deleted the pr/kconfig/atmega128rfa1_boards_symbols branch June 22, 2020 15:07
@leandrolanzieri
Copy link
Contributor Author

Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterKietzmann PeterKietzmann PeterKietzmann approved these changes

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@benpicco benpicco Awaiting requested review from benpicco

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@cgundogan cgundogan Awaiting requested review from cgundogan

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@smlng smlng Awaiting requested review from smlng

Assignees
No one assigned
Labels
Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: AVR Platform: This PR/issue effects AVR-based platforms Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Milestone
Release 2020.07
Development

Successfully merging this pull request may close these issues.
2 participants
@leandrolanzieri @PeterKietzmann