Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards/esp-based: Model features in Kconfig #14223

Merged
merged 17 commits into from
Jul 7, 2020
Merged

boards/esp-based: Model features in Kconfig #14223

merged 17 commits into from
Jul 7, 2020

Conversation

leandrolanzieri
Copy link
Contributor

Contribution description

This models in Kconfig all the features of the esp8266 and esp32 boards:

  • esp32-heltec-lora32-v2
  • esp32-mh-et-live-minikit
  • esp32-olimex-evb
  • esp32-ttgo-t-beam
  • esp32-wemos-lolin-d32-pro
  • esp32-wroom-32
  • esp32-wrover-kit
  • esp8266-esp-12x
  • esp8266-olimex-mod
  • esp8266-sparkfun-thing

Testing procedure

  • Check the symbol organization
  • Green CI
  • tests/kconfig_features should pass for all boards. Which means that make info-features-provided and make dependency-debug-features-provided-kconfig should return the same list.

Issues/PRs references

Part of #14148

@leandrolanzieri leandrolanzieri added Type: new feature The issue requests / The PR implemements a new feature for RIOT Area: Kconfig Area: Kconfig integration labels Jun 8, 2020
@leandrolanzieri leandrolanzieri requested a review from gschorcht June 8, 2020 10:11
@jia200x jia200x mentioned this pull request Jun 8, 2020
Closed
@leandrolanzieri leandrolanzieri force-pushed the pr/kconfig/esp_boards_symbols branch from 22ebcc8 to 1dbb1c8 Compare June 17, 2020 09:13
@leandrolanzieri
Copy link
Contributor Author

Adapted to the new symbol classification

@leandrolanzieri leandrolanzieri force-pushed the pr/kconfig/esp_boards_symbols branch from 1dbb1c8 to ef19441 Compare June 22, 2020 12:35
MrKevinWeiss
MrKevinWeiss previously approved these changes Jun 22, 2020
View reviewed changes
Copy link
Contributor

@MrKevinWeiss MrKevinWeiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, lets see what murdock says. ACK!

@MrKevinWeiss MrKevinWeiss added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jun 22, 2020
@MrKevinWeiss MrKevinWeiss dismissed their stale review June 22, 2020 13:39

CPU_MODEL issues

@MrKevinWeiss
Copy link
Contributor

I guess the correct way to move forward is to set the CPU_MODEL correctly in the makefiles. It appears that CPU_MODEL is not being used for anything and should not change normal operation in RIOT.

@leandrolanzieri
Copy link
Contributor Author

I guess the correct way to move forward is to set the CPU_MODEL correctly in the makefiles. It appears that CPU_MODEL is not being used for anything and should not change normal operation in RIOT.

Done

@leandrolanzieri leandrolanzieri added this to the Release 2020.07 milestone Jun 22, 2020
MrKevinWeiss
MrKevinWeiss approved these changes Jun 23, 2020
View reviewed changes
Copy link
Contributor

@MrKevinWeiss MrKevinWeiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better, I ACK! If anyone has reservations speak up now, I don't want to leave this too long and it always needing rebasing.

@MrKevinWeiss
Copy link
Contributor

Please squash

@gschorcht
Copy link
Contributor

gschorcht commented Jul 7, 2020 •
edited
Loading

Or shall we apply the small cleanup from PR #14117 here as well?

Would this be to cherry-pick e74e062 ? Is it OK without the rest of the PR?

Yes and yes.

@jeandudey @gschorcht @leandrolanzieri
boards/common/esp32: move ESP features to cpu/esp_common
3003cf7 
>All of them are features of each ESP SoC and have not to be configured by the
board definition.

Signed-off-by: Jean Pierre Dudey <[email protected]>
Co-authored-by: Gunar Schorcht <[email protected]>
@leandrolanzieri leandrolanzieri force-pushed the pr/kconfig/esp_boards_symbols branch from 0cfe648 to 887ed43 Compare July 7, 2020 14:03
@leandrolanzieri
Copy link
Contributor Author

@gschorcht done. I added the commit that moves the features. #14117 will still need to modify the Kconfig to add the definition and select esp_wifi_ap feature

gschorcht
gschorcht approved these changes Jul 7, 2020
View reviewed changes
Copy link
Contributor

@gschorcht gschorcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.

@leandrolanzieri
cpu/esp_common: Add Kconfig symbols
e6b698c
@leandrolanzieri
cpu/esp32: Add Kconfig symbols
0b0a03b
@leandrolanzieri
boards/common: Add Kconfig symbols
597c565
@leandrolanzieri
boards/esp32-heltec-lora32-v2: Add Kconfig symbols
689eea7
@leandrolanzieri
boards/esp32-mh-et-live-minikit: Add Kconfig symbols
c8428a1
@leandrolanzieri
boards/esp32-olimex-evb: Add Kconfig symbols
be5b169
@leandrolanzieri
boards/esp32-ttgo-t-beam: Add Kconfig symbols
595a433
@leandrolanzieri
boards/esp32-wemos-lolin-d32-pro: Add Kconfig symbols
46a2fd7
@leandrolanzieri
boards/esp32-wroom-32: Add Kconfig symbols
4804757
@leandrolanzieri
boards/esp32-wrover-kit: Add Kconfig symbols
6dd0d90
@leandrolanzieri
cpu/esp8266: Add Kconfig symbols
7a2e4c8
@leandrolanzieri
boards/common/esp8266: Add Kconfig symbols
85b674d
@leandrolanzieri
boards/esp8266-esp-12x: Add Kconfig symbols
d5bfce9
@leandrolanzieri
boards/esp8266-olimex-mod: Add Kconfig symbols
0b26d99
@leandrolanzieri
boards/esp8266-sparkfun-thing: Add Kconfig symbols
a4f9fbb
@leandrolanzieri
tests/kconfig_features: Add esp-based boards to whitelist
c6eaae9
@leandrolanzieri leandrolanzieri force-pushed the pr/kconfig/esp_boards_symbols branch from 887ed43 to c6eaae9 Compare July 7, 2020 14:35
@leandrolanzieri leandrolanzieri added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jul 7, 2020
@gschorcht gschorcht merged commit f320638 into RIOT-OS:master Jul 7, 2020
@gschorcht
Copy link
Contributor

@leandrolanzieri Thanks for this contribution.

@leandrolanzieri
Copy link
Contributor Author

Thanks for the review and the suggestions!

@leandrolanzieri leandrolanzieri deleted the pr/kconfig/esp_boards_symbols branch July 8, 2020 06:24
@gschorcht gschorcht mentioned this pull request Jul 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrKevinWeiss MrKevinWeiss MrKevinWeiss approved these changes

@gschorcht gschorcht gschorcht approved these changes

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@cgundogan cgundogan Awaiting requested review from cgundogan

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@smlng smlng Awaiting requested review from smlng

Assignees
No one assigned
Labels
Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Milestone
Release 2020.07
Development

Successfully merging this pull request may close these issues.
4 participants
@leandrolanzieri @MrKevinWeiss @gschorcht @jeandudey