-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests/lwip: add blackpill to BOARD_INSUFFICIENT_MEMORY #14255
tests/lwip: add blackpill to BOARD_INSUFFICIENT_MEMORY #14255
Conversation
this is very weird, a ccache clean on one of the workers solved the problem. This makes me loose quite some trust in ccache. Anyhow, the test fits only by a small margin on the blackpill. With a newer gcc (like gcc 10.1 on arch) I cannot build anymore. Thus I suggest blacklisting now. |
Locally |
Also by around 1Kib |
I tracked it down to ccache turning absolute paths into relative, e.g.,
This are the objdump outputs of one of the files. I think the assertions include the filename. |
Can you add a comment on why we are blacklisting? pointing to the issue maybe that way if its fixed we can remove form the blacklist? |
it is added to BOARD_INSUFFICIENT_MEMORY because it is too fat. it just happens to be so borderline that it sometimes actually fits (#14264). Regular compiles (e.g., locally, even in docker container) that contain the full Not sure that justifies an extra comment? |
OK! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK.
Contribution description
Somehow this doesn't link on master anymore (test go too large), so blacklist it.
Testing procedure
make -Ctests/lwip BOARD=blackpill all
fails on master, won't be built with this PR.Issues/PRs references
Popped up e.g, here: https://ci.riot-os.org/RIOT-OS/RIOT/14205/3dea09894deea99e8a6739939e52799b680c2313/output/compile/tests/lwip/blackpill:gnu.txt