Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards/efm32-based: Model features in Kconfig #14310

Merged

Conversation

leandrolanzieri
Copy link
Contributor

Contribution description

This models in Kconfig all the features of the efm32-based boards:

  • ikea-tradfri
  • slstk3401a
  • slstk3402a
  • sltb001a
  • slwstk6000b-slwrb4150a
  • slwstk6000b-slwrb4162a
  • stk3600
  • stk3700

Testing procedure

  • Check the symbol organization
  • Green CI
  • tests/kconfig_features should pass for all boards

Issues/PRs references

Part of #14148

@leandrolanzieri leandrolanzieri added Type: new feature The issue requests / The PR implemements a new feature for RIOT Area: Kconfig Area: Kconfig integration labels Jun 18, 2020
@basilfx basilfx added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jun 18, 2020
@basilfx
Copy link
Member

basilfx commented Jun 18, 2020

@leandrolanzieri I guess that there is not much to test, except that it passes CI?

@leandrolanzieri
Copy link
Contributor Author

@leandrolanzieri I guess that there is not much to test, except that it passes CI?

Yes, that and that the symbol organization makes sense. In this case it was pretty straightforward because the CPUs are nicely organized in families (thanks for that :)

@basilfx
Copy link
Member

basilfx commented Jun 19, 2020

Should the modules like USEMODULE += silabs_aem also be in there? I do see USEMODULE += boards_common_silabs though.

@leandrolanzieri
Copy link
Contributor Author

Should the modules like USEMODULE += silabs_aem also be in there? I do see USEMODULE += boards_common_silabs though.

No, this is only to model features. BOARD_COMMON_SILABS is a symbol to provide the common features, it is not related with the module boards_common_silabs.

@basilfx
Copy link
Member

basilfx commented Jun 19, 2020

That makes sense. Thanks for explaining.

@leandrolanzieri leandrolanzieri added this to the Release 2020.07 milestone Jun 19, 2020
Copy link
Member

@cgundogan cgundogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also took a secondary look and the diff seems to be fine. Murdock also passes the tests. ACK

@cgundogan cgundogan merged commit 209248f into RIOT-OS:master Jun 19, 2020
@cgundogan cgundogan added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels Jun 19, 2020
@leandrolanzieri
Copy link
Contributor Author

Thanks for reviewing!

@leandrolanzieri leandrolanzieri deleted the pr/kconfig/efm32_boards_symbols branch June 19, 2020 13:22
@aabadie aabadie mentioned this pull request Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants