Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/cord : Expose configurations to Kconfig #14321

Merged
merged 6 commits into from
Sep 7, 2020
Merged

net/cord : Expose configurations to Kconfig #14321

merged 6 commits into from
Sep 7, 2020

Conversation

akshaim
Copy link
Member

@akshaim akshaim commented Jun 20, 2020 •
edited
Loading

Contribution description - [Updated]

This PR exposes compile configurations in net/cord to Kconfig.

Skipped CORD_STARTUP_DELAY since it was not being used.

Testing procedure

  1. New documentation was built using Doxygen

    The build works fine.

  2. Test files were added to tests/net_cord/

    The test file can be found here

    Compiled binaries for native

Default State:

Firmware Output
RIOT native interrupts/signals initialized.
LED_RED_OFF
LED_GREEN_ON
RIOT native board initialized.
RIOT native hardware initialization complete.

main(): This is RIOT! (Version: 2020.07-devel-1360-g9f894-Kconfig_cord_tests)
CONFIG_CORD_LT=(86400UL)
CONFIG_CORD_UPDATE_INTERVAL=(((86400UL) / 4) * 3)
CONFIG_CORD_EP=CONFIG_CORD_EP

Usage with CFLAGS :

CFLAGS += -DCONFIG_CORD_LT=5000
CFLAGS += -DCONFIG_CORD_UPDATE_INTERVAL=3000
CFLAGS += -DCONFIG_CORD_EP=\"Newname\"
Firmware Output
RIOT native interrupts/signals initialized.
LED_RED_OFF
LED_GREEN_ON
RIOT native board initialized.
RIOT native hardware initialization complete.

main(): This is RIOT! (Version: 2020.07-devel-1361-g660b8-Kconfig_cord_tests)
CONFIG_CORD_LT=5000
CONFIG_CORD_UPDATE_INTERVAL=3000
CONFIG_CORD_EP="Newname"

Usage with menuconfig :

make menuconfig

Firmware Output
RIOT native interrupts/signals initialized.
LED_RED_OFF
LED_GREEN_ON
RIOT native board initialized.
RIOT native hardware initialization complete.

main(): This is RIOT! (Version: 2020.07-devel-1361-g4c9b7a-Kconfig_cord_tests)
CONFIG_CORD_LT=86400
CONFIG_CORD_UPDATE_INTERVAL=61800
CONFIG_CORD_EP="Testname"

MACROS were successfully configured.

Issues/PRs references

#12888

@leandrolanzieri leandrolanzieri added Area: Kconfig Area: Kconfig integration Type: new feature The issue requests / The PR implemements a new feature for RIOT labels Jun 22, 2020
leandrolanzieri
leandrolanzieri reviewed Jun 22, 2020
View reviewed changes
examples/cord_ep/Makefile Show resolved Hide resolved
sys/net/application_layer/cord/Kconfig Outdated Show resolved Hide resolved
sys/net/application_layer/cord/Kconfig Show resolved Hide resolved
@leandrolanzieri leandrolanzieri mentioned this pull request Jun 22, 2020
Open
71 tasks
@akshaim
Copy link
Member Author

akshaim commented Jun 23, 2020

@haukepetersen Hi. Do you think I should expose CORD_EP_SUFFIX_LEN and CORD_EP_PREFIX as well to Kconfig ?

@leandrolanzieri
Copy link
Contributor

This needs rebasing

@leandrolanzieri
Copy link
Contributor

Please squash

@leandrolanzieri leandrolanzieri added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines labels Sep 7, 2020
@leandrolanzieri leandrolanzieri added the Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines label Sep 7, 2020
@leandrolanzieri leandrolanzieri added this to the Release 2020.10 milestone Sep 7, 2020
leandrolanzieri
leandrolanzieri approved these changes Sep 7, 2020
View reviewed changes
Copy link
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@leandrolanzieri leandrolanzieri merged commit 40b52e1 into RIOT-OS:master Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leandrolanzieri leandrolanzieri leandrolanzieri approved these changes

@cgundogan cgundogan Awaiting requested review from cgundogan

@haukepetersen haukepetersen Awaiting requested review from haukepetersen

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

@PeterKietzmann PeterKietzmann Awaiting requested review from PeterKietzmann PeterKietzmann is a code owner

Assignees
No one assigned
Labels
Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Milestone
Release 2020.10
Development

Successfully merging this pull request may close these issues.
2 participants
@akshaim @leandrolanzieri