Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards/nrf-based: Model features in Kconfig #14440

Merged
merged 32 commits into from
Jul 16, 2020
Merged

boards/nrf-based: Model features in Kconfig #14440

merged 32 commits into from
Jul 16, 2020

Conversation

leandrolanzieri
Copy link
Contributor

Contribution description

This models the provided features for all nrf5x-based boards:

  • acd52832
  • adafruit-clue
  • airfy-beacon
  • arduino-nano-33-ble
  • calliope-mini
  • dwm1001
  • feather-nrf52840
  • microbit
  • nrf51dk
  • nrf51dongle
  • nrf52832-mdk
  • nrf52840-mdk
  • nrf52840dk
  • nrf52840dongle
  • nrf52dk
  • nrf6310
  • particle-argon
  • particle-boron
  • particle-xenon
  • pinetime
  • reel
  • ruuvitag
  • thingy52
  • yunjia-nrf51822

Testing procedure

  • Check the symbol organization and naming
  • tests/kconfig_features should pass for all boards

Issues/PRs references

Part of #14148

@leandrolanzieri leandrolanzieri added Type: new feature The issue requests / The PR implemements a new feature for RIOT Area: Kconfig Area: Kconfig integration labels Jul 6, 2020
@leandrolanzieri leandrolanzieri requested a review from fjmolinas July 6, 2020 06:44
@jia200x jia200x mentioned this pull request Jul 6, 2020
Closed
aabadie
aabadie reviewed Jul 15, 2020
View reviewed changes
cpu/nrf5x_common/Kconfig Outdated Show resolved Hide resolved
@aabadie aabadie self-assigned this Jul 15, 2020
@leandrolanzieri leandrolanzieri force-pushed the pr/kconfig/nrf_based_boards_symbols branch from cd9fc79 to 4994351 Compare July 16, 2020 08:03
@leandrolanzieri
Copy link
Contributor Author

I've renamed the symbol and rebased to master to resolve the conflict in the Makefile.

@aabadie
Copy link
Contributor

aabadie commented Jul 16, 2020

please squash and let's see what Murdock has to say

@leandrolanzieri
boards/microbit: Add Kconfig symbols
013296c
@leandrolanzieri
boards/nrf51dk: Add Kconfig symbols
1a2ac51
@leandrolanzieri
boards/nrf51dongle: Add Kconfig symbols
5d1b03e
@leandrolanzieri
boards/nrf52832-mdk: Add Kconfig symbols
a6074a2
@leandrolanzieri
boards/nrf52840-mdk: Add Kconfig symbols
c6efe09
@leandrolanzieri
boards/nrf52840dk: Add Kconfig symbols
bddc613
@leandrolanzieri
boards/nrf52840dongle: Add Kconfig symbols
21ed030
@leandrolanzieri
boards/nrf52dk: Add Kconfig symbols
72231d3
@leandrolanzieri
boards/nrf6310: Add Kconfig symbols
8026783
@leandrolanzieri
boards/particle-argon: Add Kconfig symbols
1d2d394
@leandrolanzieri
boards/particle-boron: Add Kconfig symbols
7f7ce04
@leandrolanzieri
boards/particle-xenon: Add Kconfig symbols
4b45dd3
@leandrolanzieri
boards/pinetime: Add Kconfig symbols
27a98ea
@leandrolanzieri
boards/reel: Add Kconfig symbols
bf16136
@leandrolanzieri
boards/ruuvitag: Add Kconfig symbols
e43ae1d
@leandrolanzieri
boards/thingy52: Add Kconfig symbols
343a132
@leandrolanzieri
boards/yunjia-nrf51822: Add Kconfig symbols
4636f68
@leandrolanzieri
test/kconfig_features: Add nrf-based boards to whitelist
204b863
@leandrolanzieri leandrolanzieri force-pushed the pr/kconfig/nrf_based_boards_symbols branch from a073758 to 204b863 Compare July 16, 2020 08:24
@leandrolanzieri leandrolanzieri added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jul 16, 2020
aabadie
aabadie approved these changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Murdock is green which means that features exposed by Kconfig are in sync with the current Make based mechanism.

Kconfig files are correct.

ACK and go!

@aabadie aabadie merged commit f722022 into RIOT-OS:master Jul 16, 2020
@leandrolanzieri
Copy link
Contributor Author

Thanks for reviewing!

@leandrolanzieri leandrolanzieri deleted the pr/kconfig/nrf_based_boards_symbols branch July 16, 2020 09:24
@leandrolanzieri leandrolanzieri added this to the Release 2020.10 milestone Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aabadie aabadie aabadie approved these changes

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

@cgundogan cgundogan Awaiting requested review from cgundogan

@haukepetersen haukepetersen Awaiting requested review from haukepetersen

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@smlng smlng Awaiting requested review from smlng

Assignees

@aabadie aabadie

Labels
Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Milestone
Release 2020.10
Development

Successfully merging this pull request may close these issues.
2 participants
@leandrolanzieri @aabadie