Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards/ek-lm4f120xl: Model features in Kconfig #14469

Merged
merged 2 commits into from
Jul 16, 2020
Merged

boards/ek-lm4f120xl: Model features in Kconfig #14469

merged 2 commits into from
Jul 16, 2020

Conversation

leandrolanzieri
Copy link
Contributor

Contribution description

This models the features of the ek-lm4f120xl board (the only that uses lm4f120 CPUs).

Testing procedure

  • Green CI
  • tests/kconfig_features should pass

Issues/PRs references

Part of #14148

@leandrolanzieri leandrolanzieri added Type: new feature The issue requests / The PR implemements a new feature for RIOT Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Area: Kconfig Area: Kconfig integration labels Jul 8, 2020
@leandrolanzieri leandrolanzieri requested a review from fjmolinas July 8, 2020 17:29
@jia200x jia200x mentioned this pull request Jul 8, 2020
Closed
@aabadie
Copy link
Contributor

aabadie commented Jul 16, 2020

Also needs a rebase

@leandrolanzieri
cpu/lm4f120: Add Kconfig symbols
52b31b5 
Also specify CPU_FAM in Makefile.features
@leandrolanzieri
boards/ek-lm4f120: Add Kconfig symbols
cb01f52 
Also add the board to the whitelist of tests/kconfig_features
@leandrolanzieri leandrolanzieri force-pushed the pr/kconfig/ek-lm4f120xl_symbols branch from f8c0364 to cb01f52 Compare July 16, 2020 11:24
@leandrolanzieri
Copy link
Contributor Author

And rebased

aabadie
aabadie approved these changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@aabadie aabadie left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and Murdock is green,...

ACK

@aabadie aabadie added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jul 16, 2020
@aabadie aabadie merged commit 4ef2f67 into RIOT-OS:master Jul 16, 2020
@leandrolanzieri leandrolanzieri deleted the pr/kconfig/ek-lm4f120xl_symbols branch July 16, 2020 13:31
@leandrolanzieri leandrolanzieri added this to the Release 2020.10 milestone Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aabadie aabadie aabadie approved these changes

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

@cgundogan cgundogan Awaiting requested review from cgundogan

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@smlng smlng Awaiting requested review from smlng

Assignees
No one assigned
Labels
Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Milestone
Release 2020.10
Development

Successfully merging this pull request may close these issues.
2 participants
@leandrolanzieri @aabadie