Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards/saml1x-based: Model features in Kconfig #14485

Merged

Conversation

leandrolanzieri
Copy link
Contributor

Contribution description

This models the features of the saml1x-based boards in Kconfig:

  • saml10-xpro
  • saml11-xpro

This PR also fixes the issue of CPU_FAM being currently set twice (once in the cpu's Makefile.features and a second time in the board's `Makefile.include, both with different values).

Testing procedure

  • Check the names and organization of the symbols
  • Green CI: tests/kconfig_features should pass for both boards

Issues/PRs references

Part of #14148

@leandrolanzieri leandrolanzieri added Area: build system Area: Build system Type: new feature The issue requests / The PR implemements a new feature for RIOT Area: Kconfig Area: Kconfig integration labels Jul 10, 2020
Copy link
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. ACK

Please rebase!

@leandrolanzieri leandrolanzieri force-pushed the pr/kconfig/saml1x_based_symbols branch from 4bcbeba to c447449 Compare July 16, 2020 16:10
@leandrolanzieri leandrolanzieri added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jul 16, 2020
@leandrolanzieri
Copy link
Contributor Author

Rebased

@aabadie aabadie merged commit 3b77845 into RIOT-OS:master Jul 16, 2020
@leandrolanzieri leandrolanzieri added this to the Release 2020.10 milestone Jul 17, 2020
@leandrolanzieri leandrolanzieri deleted the pr/kconfig/saml1x_based_symbols branch July 17, 2020 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: build system Area: Build system Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants