Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/dhcpv6 : Expose configurations to Kconfig #14599

Merged
merged 4 commits into from
Jul 28, 2020
Merged

net/dhcpv6 : Expose configurations to Kconfig #14599

merged 4 commits into from
Jul 28, 2020

Conversation

akshaim
Copy link
Member

@akshaim akshaim commented Jul 24, 2020

Contribution description

This PR exposes compile configurations in net/dhcpv6 to Kconfig.

Skipped DHCPV6_CLIENT_SERVER_MAX as its unused.

Testing procedure

  1. New documentation was built using Doxygen

    The build works fine.

  2. Test files were added to tests/net_dhcpv6/

    The test file can be found here

    Compiled binaries for native

  3. examples/gnrc_border_router

    Build works fine for native.

Default State:

Firmware Output
RIOT native interrupts/signals initialized.
LED_RED_OFF
LED_GREEN_ON
RIOT native board initialized.
RIOT native hardware initialization complete.

main(): This is RIOT! (Version: 2020.10-devel-344-g4e2b5-Kconfig_dhcpv6_tests)
CONFIG_DHCPV6_CLIENT_PFX_LEASE_MAX=(1U)

Usage with CFLAGS :

CFLAGS += -DCONFIG_DHCPV6_CLIENT_PFX_LEASE_MAX=2
Firmware Output
RIOT native interrupts/signals initialized.
LED_RED_OFF
LED_GREEN_ON
RIOT native board initialized.
RIOT native hardware initialization complete.

main(): This is RIOT! (Version: 2020.10-devel-344-g4e2b5-Kconfig_dhcpv6_tests)
CONFIG_DHCPV6_CLIENT_PFX_LEASE_MAX=2

Usage with menuconfig :

make menuconfig

Default values

RIOT native interrupts/signals initialized.
LED_RED_OFF
LED_GREEN_ON
RIOT native board initialized.
RIOT native hardware initialization complete.

main(): This is RIOT! (Version: 2020.10-devel-344-g4e2b5-Kconfig_dhcpv6_tests)
CONFIG_DHCPV6_CLIENT_PFX_LEASE_MAX=1
Macros Configured output
RIOT native interrupts/signals initialized.
LED_RED_OFF
LED_GREEN_ON
RIOT native board initialized.
RIOT native hardware initialization complete.

main(): This is RIOT! (Version: 2020.10-devel-344-g4e2b5-Kconfig_dhcpv6_tests)
CONFIG_DHCPV6_CLIENT_PFX_LEASE_MAX=4

MACROS were successfully configured.

Issues/PRs references

#12888

akshaim added 3 commits July 23, 2020 21:10
@akshaim
net/dhcpv6 : Move 'DHCPV6_CLIENT_PFX_LEASE_MAX' to 'CONFIG_'
1c37e11
@akshaim
net/dhcpv6 : Expose to Kconfig
0413a58 
Expose configurations to Kconfig. Add conditional CFLAGS to avoid
conflicts with Kconfig.
@akshaim
net/dhcpv6 : Update documentation
6be6300 
Add configuration 'CONFIG_DHCPV6_CLIENT_PFX_LEASE_MAX' to
configuration group
@leandrolanzieri leandrolanzieri added Area: Kconfig Area: Kconfig integration Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation labels Jul 24, 2020
@leandrolanzieri leandrolanzieri mentioned this pull request Jul 24, 2020
Open
71 tasks
@leandrolanzieri
Copy link
Contributor

@miri64 DHCPV6_CLIENT_SERVER_MAX seems to be unused, do you think we could remove it?

@leandrolanzieri leandrolanzieri added this to the Release 2020.10 milestone Jul 24, 2020
@leandrolanzieri leandrolanzieri added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jul 24, 2020
@miri64
Copy link
Member

miri64 commented Jul 27, 2020

@miri64 DHCPV6_CLIENT_SERVER_MAX seems to be unused, do you think we could remove it?

I guess I originally planned to support more than one server, but it is indeed not used. So we probably can remove it for now to avoid confusion.

@akshaim
net/dhcpv6 : Remove unused macro
a9e0a11 
Remove unused macro 'DHCPV6_CLIENT_SERVER_MAX'
@akshaim
Copy link
Member Author

akshaim commented Jul 28, 2020 •
edited
Loading

@miri64 DHCPV6_CLIENT_SERVER_MAX seems to be unused, do you think we could remove it?

I guess I originally planned to support more than one server, but it is indeed not used. So we probably can remove it for now to avoid confusion.

Done.

@leandrolanzieri leandrolanzieri added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines labels Jul 28, 2020
leandrolanzieri
leandrolanzieri approved these changes Jul 28, 2020
View reviewed changes
Copy link
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Macro is generated correctly and documentation looks good. There are also no more occurrences of DHCPV6_CLIENT_SERVER_MAX. ACK.

@leandrolanzieri leandrolanzieri added Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels Jul 28, 2020
@leandrolanzieri leandrolanzieri merged commit cfdf304 into RIOT-OS:master Jul 28, 2020
@akshaim akshaim deleted the Kconfig_dhcpv6 branch July 28, 2020 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leandrolanzieri leandrolanzieri leandrolanzieri approved these changes

@cgundogan cgundogan Awaiting requested review from cgundogan

@haukepetersen haukepetersen Awaiting requested review from haukepetersen

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

@PeterKietzmann PeterKietzmann Awaiting requested review from PeterKietzmann PeterKietzmann is a code owner

Assignees
No one assigned
Labels
Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2020.10
Development

Successfully merging this pull request may close these issues.
3 participants
@akshaim @leandrolanzieri @miri64