Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/lwip_sock_tcp: remove duplicated xtimer_init #15189

Merged
merged 1 commit into from
Oct 8, 2020
Merged

tests/lwip_sock_tcp: remove duplicated xtimer_init #15189

merged 1 commit into from
Oct 8, 2020

Conversation

fjmolinas
Copy link
Contributor

Contribution description

xtimer is already initiated in auto_init, no need to perform
initiation twice.

Testing procedure

Run tests/lwip_sock_tcp.

Issues/PRs references

Found in #15186

@fjmolinas fjmolinas added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) CI: run tests If set, CI server will run tests on hardware for the labeled PR labels Oct 8, 2020
@fjmolinas fjmolinas requested a review from miri64 as a code owner October 8, 2020 14:12
@fjmolinas fjmolinas added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Oct 8, 2020
@leandrolanzieri leandrolanzieri added the Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch label Oct 8, 2020
@fjmolinas
tests/lwip_sock_tcp: remove duplicated xtimer_init
7ec1d2e 
xtimer is already initiated in auto_init, no need to perform
initiation twice.
@fjmolinas fjmolinas force-pushed the pr_lwip_sock_tcp_xtimer_init branch from 61c150d to 7ec1d2e Compare October 8, 2020 14:26
@leandrolanzieri
Copy link
Contributor

The failing test is unrelated to the changes.

@leandrolanzieri leandrolanzieri added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: run tests If set, CI server will run tests on hardware for the labeled PR CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 8, 2020
leandrolanzieri
leandrolanzieri approved these changes Oct 8, 2020
View reviewed changes
Copy link
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change makes sense and the test is passing. ACK.

@leandrolanzieri leandrolanzieri added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines labels Oct 8, 2020
@leandrolanzieri leandrolanzieri added this to the Release 2020.10 milestone Oct 8, 2020
@benpicco benpicco added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 8, 2020
@benpicco benpicco merged commit a83927d into RIOT-OS:master Oct 8, 2020
@fjmolinas fjmolinas deleted the pr_lwip_sock_tcp_xtimer_init branch October 9, 2020 07:28
@fjmolinas fjmolinas mentioned this pull request Oct 9, 2020
Merged
@fjmolinas
Copy link
Contributor Author

Backport provided in #15191

@fjmolinas
Copy link
Contributor Author

Thanks or the review and spotting the issue @leandrolanzieri!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leandrolanzieri leandrolanzieri leandrolanzieri approved these changes

@miri64 miri64 Awaiting requested review from miri64

Assignees
No one assigned
Labels
CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2020.10
Development

Successfully merging this pull request may close these issues.
3 participants
@fjmolinas @leandrolanzieri @benpicco