Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers/rn2xx3 : Kconfig updates. #15573

Merged
merged 2 commits into from
Dec 8, 2020
Merged

drivers/rn2xx3 : Kconfig updates. #15573

merged 2 commits into from
Dec 8, 2020

Conversation

akshaim
Copy link
Member

@akshaim akshaim commented Dec 7, 2020 •
edited
Loading

Contribution description -

This PR replaces LORAMAC_DEFAULT_AR with CONFIG_RN2XX3_DEFAULT_AR and expose the same to Kconfig. Auto reply is a device-specific feature and not part of LoRaWAN specification.

Testing procedure

  1. New documentation was built using Doxygen

    The build works fine.

  2. Test files were updated in tests/driver_rn2xx3

    The test file can be found here

    Compiled binaries for sam21 and tested on FIT-IoT Test bed.

Default State:

Firmware Output
main(): This is RIOT! (Version: 2021.01-devel-1397-g150a85-Kconfig_rn2xx3_update)
RN2XX3 device driver test
CONFIG_RN2XX3_DEFAULT_SLEEP=(5000U)
CONFIG_RN2XX3_DEFAULT_AR=CONFIG_RN2XX3_DEFAULT_AR

Usage with menuconfig :

make menuconfig

Default Firmware Output
main(): This is RIOT! (Version: 2021.01-devel-1397-g150a85-Kconfig_rn2xx3_update)
RN2XX3 device driver test
CONFIG_RN2XX3_DEFAULT_SLEEP=5000
CONFIG_RN2XX3_DEFAULT_AR=CONFIG_RN2XX3_DEFAULT_AR
Configured Firmware Output
main(): This is RIOT! (Version: 2021.01-devel-1397-g150a85-Kconfig_rn2xx3_update)
RN2XX3 device driver test
CONFIG_RN2XX3_DEFAULT_SLEEP=6000
CONFIG_RN2XX3_DEFAULT_AR=1

MACROS were successfully configured.

Issues/PRs references

#12888
#15507

@akshaim akshaim marked this pull request as ready for review December 7, 2020 16:51
@leandrolanzieri leandrolanzieri added Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation labels Dec 8, 2020
@leandrolanzieri leandrolanzieri added this to the Release 2021.01 milestone Dec 8, 2020
akshaim and others added 2 commits December 8, 2020 11:33
@akshaim @leandrolanzieri
drivers/rn2xx3 : r/LORAMAC_DEFAULT_AR/CONFIG_RN2XX3_DEFAULT_AR
bfd3a90 
Move 'LORAMAC_DEFAULT_AR' to drivers/rn2xx3 i.e
'RN2XX3_DEFAULT_AR'
Move 'RN2XX3_DEFAULT_AR' to 'CONFIG_' namespace

Co-authored-by: Leandro Lanzieri <[email protected]>
@akshaim
drivers/rn2xx3 : Update Kconfig
95394c4 
Expose CONFIG_RN2XX3_DEFAULT_AR to Kconfig
@akshaim akshaim force-pushed the Kconfig_rn2xx3_update branch from e201d34 to 95394c4 Compare December 8, 2020 10:34
leandrolanzieri
leandrolanzieri approved these changes Dec 8, 2020
View reviewed changes
Copy link
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward, makes sense to move this to the driver's configurations. ACK.

@leandrolanzieri leandrolanzieri added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels Dec 8, 2020
@leandrolanzieri leandrolanzieri merged commit 06a06c3 into RIOT-OS:master Dec 8, 2020
@akshaim akshaim mentioned this pull request Dec 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leandrolanzieri leandrolanzieri leandrolanzieri approved these changes

@cgundogan cgundogan Awaiting requested review from cgundogan

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

Assignees
No one assigned
Labels
Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2021.01
Development

Successfully merging this pull request may close these issues.
2 participants
@akshaim @leandrolanzieri