Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpu/stm32/gpio: fix EXTI flag clearing [backport 2021.01] #15905

Merged
merged 1 commit into from
Feb 2, 2021
Merged

cpu/stm32/gpio: fix EXTI flag clearing [backport 2021.01] #15905

merged 1 commit into from
Feb 2, 2021

Conversation

benpicco
Copy link
Contributor

@benpicco benpicco commented Feb 1, 2021

Backport of #15899

Contribution description

In case a non-gpio EXTI (>= 16) is pending, the isr_exti() used to clear
the flag and try to call a callback, which was out-of-bouds, thus
generating a hard fault.
This fixes it by masking the pending_isr variables with 0xFFFF.

Issues/PRs references

#14564

@benpicco
cpu/stm32/gpio: fix EXTI flag clearing
658f6de 
In case a non-gpio EXTI (>= 16) is pending, the isr_exti() used to clear
the flag and try to call a callback, which was out-of-bouds, thus
generating a hard fault.
This fixes it by masking the pending_isr variables with 0xFFFF.

(cherry picked from commit 3e8e109)
@benpicco benpicco added Area: cpu Area: CPU/MCU ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) labels Feb 1, 2021
@benpicco benpicco requested review from aabadie and jia200x February 1, 2021 17:23
@benpicco benpicco added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Feb 1, 2021
jia200x
jia200x approved these changes Feb 1, 2021
View reviewed changes
Copy link
Member

@jia200x jia200x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@maribu
Copy link
Member

maribu commented Feb 1, 2021

CI glitch: dwqw: command timed out. Let's give it another spin.

@maribu maribu added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Feb 1, 2021
@jia200x jia200x merged commit ce1ca91 into RIOT-OS:2021.01-branch Feb 2, 2021
@jia200x jia200x mentioned this pull request Feb 2, 2021
Closed
88 tasks
@benpicco benpicco deleted the backport/2021.01/pr/stm32-fix-exti branch February 2, 2021 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jia200x jia200x jia200x approved these changes

@MrKevinWeiss MrKevinWeiss Awaiting requested review from MrKevinWeiss MrKevinWeiss is a code owner

@aabadie aabadie Awaiting requested review from aabadie

Assignees
No one assigned
Labels
Area: cpu Area: CPU/MCU ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benpicco @maribu @jia200x