Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnrc_netif_pktq: add function to check usage #16193

Merged
merged 2 commits into from
Mar 18, 2021
Merged

gnrc_netif_pktq: add function to check usage #16193

merged 2 commits into from
Mar 18, 2021

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Mar 15, 2021

Contribution description

This adds a new function to the API of gnrc_netif_pktq to check how much resources (i.e. number of entries in the pool) are currently in use.

Testing procedure

I extended the unittests, so they should still pass.

gnrc_netif_pktq: add function to check usage

Issues/PRs references

None

@miri64 miri64 added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: network Area: Networking labels Mar 15, 2021
@miri64 miri64 requested a review from jia200x March 15, 2021 14:25
@jia200x
Copy link
Member

jia200x commented Mar 15, 2021

It passes:

main(): This is RIOT! (Version: 2021.04-devel-1037-g6507d-copr/16193)
Help: Press s to start test, r to print it is ready
READY
s
START
.........
OK (9 tests)

@miri64 miri64 mentioned this pull request Mar 15, 2021
Merged
jia200x
jia200x approved these changes Mar 17, 2021
View reviewed changes
Copy link
Member

@jia200x jia200x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@miri64 miri64 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Mar 17, 2021
@miri64
Copy link
Member Author

miri64 commented Mar 17, 2021

Thanks!

@miri64
Copy link
Member Author

miri64 commented Mar 18, 2021

The failing test seems unrelated, but will have a look.

@miri64
Copy link
Member Author

miri64 commented Mar 18, 2021

Mhhhh could not reproduce locally. I will rerun Murdock.

@miri64 miri64 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 18, 2021
@kaspar030 kaspar030 mentioned this pull request Mar 18, 2021
Merged
@kaspar030 kaspar030 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 18, 2021
@miri64
Copy link
Member Author

miri64 commented Mar 18, 2021

Thanks @kaspar030 for investigating and for fixing! Let's go with this one!

@miri64 miri64 merged commit 214fdf0 into RIOT-OS:master Mar 18, 2021
@kaspar030 kaspar030 added this to the Release 2021.04 milestone Apr 23, 2021
@miri64 miri64 deleted the gnrc_netif_pktq/feat/usage branch May 6, 2021 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jia200x jia200x jia200x approved these changes

@cgundogan cgundogan Awaiting requested review from cgundogan

@haukepetersen haukepetersen Awaiting requested review from haukepetersen

@PeterKietzmann PeterKietzmann Awaiting requested review from PeterKietzmann PeterKietzmann is a code owner

Assignees
No one assigned
Labels
Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2021.04
Development

Successfully merging this pull request may close these issues.
3 participants
@miri64 @jia200x @kaspar030