Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-actions: release-tests: properly configure GH token for sudo #16350

Merged
merged 1 commit into from
Apr 20, 2021
Merged

gh-actions: release-tests: properly configure GH token for sudo #16350

merged 1 commit into from
Apr 20, 2021

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Apr 20, 2021

Contribution description

Another follow-up on #15637. pytest reads the token from the HOME directory, which with sudo is root, so there is none (since it is in the login user's HOME), so it can't comment in the tracking issue for sudo the tasks.

Testing procedure

I started a run in https://github.com/miri64/RIOT/actions/runs/766574330. Murdock should comment from there.

Issues/PRs references

Follow-up on #15637

@miri64 miri64 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: CI Area: Continuous Integration of RIOT components Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs labels Apr 20, 2021
@miri64 miri64 added this to the Release 2021.04 milestone Apr 20, 2021
@miri64 miri64 requested review from aabadie and kaspar030 April 20, 2021 09:14
@miri64 miri64 mentioned this pull request Apr 20, 2021
Closed
88 tasks
kaspar030
kaspar030 approved these changes Apr 20, 2021
View reviewed changes
Copy link
Contributor

@kaspar030 kaspar030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@miri64
Copy link
Member Author

miri64 commented Apr 20, 2021

For reference: it works: RIOT-OS/Release-Specs#213 (comment)

@miri64
Copy link
Member Author

miri64 commented Apr 20, 2021 •
edited
Loading

To make sure the IoT-LAB creds tests are also still commented, I unset 4.3 in RIOT-OS/Release-Specs#213 OP

@miri64
Copy link
Member Author

miri64 commented Apr 20, 2021

To make sure the IoT-LAB creds tests are also still commented, I unset 4.3 in RIOT-OS/Release-Specs#213 OP

Does work: RIOT-OS/Release-Specs#213 (comment)

@kaspar030
Copy link
Contributor

Then let's go!

@kaspar030 kaspar030 merged commit 8951493 into RIOT-OS:master Apr 20, 2021
@miri64 miri64 deleted the gh-actions/fix/release-test-sudo-gh-token branch April 20, 2021 14:35
@miri64 miri64 mentioned this pull request Apr 20, 2021
Merged
@miri64
Copy link
Member Author

miri64 commented Apr 20, 2021

Backport provided in #16356

@kaspar030 kaspar030 added the Release notes: ignored Set on PRs that have been considered for inclusion in the current release's notes but were minor. label Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaspar030 kaspar030 kaspar030 approved these changes

@aabadie aabadie Awaiting requested review from aabadie

Assignees
No one assigned
Labels
Area: CI Area: Continuous Integration of RIOT components CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch Release notes: ignored Set on PRs that have been considered for inclusion in the current release's notes but were minor. Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2021.04
Development

Successfully merging this pull request may close these issues.
2 participants
@miri64 @kaspar030