Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-actions: release-tests: do not run linters for release tests #16379

Merged
merged 1 commit into from
Apr 23, 2021
Merged

gh-actions: release-tests: do not run linters for release tests #16379

merged 1 commit into from
Apr 23, 2021

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Apr 23, 2021

Contribution description

The release tests are marked as failing currenty since there is a bug in pylint (or one of its libraries). There is not much sense to run the linter for the release tests on the test scripts, as this is already done in the CI of the release tests. As such, we only need to run the test environment of tox, which executes the release tests.

Testing procedure

I'll run the workflow in my fork, just to see if everything works (to shorten the runtime a REMOVE ME commit is included).

Issues/PRs references

See RIOT-OS/Release-Specs#213 (comment)

@miri64 miri64 added the Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation label Apr 23, 2021
@miri64
Copy link
Member Author

miri64 commented Apr 23, 2021

I'll run the workflow in my fork, just to see if everything works (to shorten the runtime a REMOVE ME commit is included).

See https://github.com/miri64/RIOT/actions/runs/777070704

@miri64 miri64 added Area: CI Area: Continuous Integration of RIOT components CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR Process: release cycle Integration Process: The PR is connected to the release cycle (e.g. release notes) labels Apr 23, 2021
@miri64
Copy link
Member Author

miri64 commented Apr 23, 2021

I'll run the workflow in my fork, just to see if everything works (to shorten the runtime a REMOVE ME commit is included).

See https://github.com/miri64/RIOT/actions/runs/777070704

Oops, TOX_ARGS, dispite its name is piped into pylint so that was the wrong entry point for that argument. Latest fixup should do the trick. See https://github.com/miri64/RIOT/actions/runs/777090015

@miri64
Copy link
Member Author

miri64 commented Apr 23, 2021

Only the test environment is run now.

@kaspar030
Copy link
Contributor

Only the test environment is run now.

that's what we want, right?

@miri64
Copy link
Member Author

miri64 commented Apr 23, 2021

Only the test environment is run now.

that's what we want, right?

Yepp, sorry for not being clear on that :-).

@kaspar030
Copy link
Contributor

Then please squash! :)

@kaspar030 kaspar030 added the Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch label Apr 23, 2021
@miri64 miri64 force-pushed the gh-actions/fix/remove-linters branch from 9a27c77 to 14d3cba Compare April 23, 2021 08:57
@miri64
Copy link
Member Author

miri64 commented Apr 23, 2021

Squashed

@miri64 miri64 added CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR labels Apr 23, 2021
kaspar030
kaspar030 approved these changes Apr 23, 2021
View reviewed changes
Copy link
Contributor

@kaspar030 kaspar030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@kaspar030 kaspar030 merged commit c0c3a76 into RIOT-OS:master Apr 23, 2021
@miri64 miri64 mentioned this pull request Apr 23, 2021
Merged
@miri64 miri64 deleted the gh-actions/fix/remove-linters branch April 23, 2021 09:05
@miri64
Copy link
Member Author

miri64 commented Apr 23, 2021

Backport provided in #16380

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaspar030 kaspar030 kaspar030 approved these changes

@aabadie aabadie Awaiting requested review from aabadie

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

Assignees
No one assigned
Labels
Area: CI Area: Continuous Integration of RIOT components CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch Process: release cycle Integration Process: The PR is connected to the release cycle (e.g. release notes) Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miri64 @kaspar030