Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh_workflows: adapt to GNRC LoRaWAN Release Test env variables #16430

Merged
merged 1 commit into from
May 4, 2021

Conversation

jia200x
Copy link
Member

@jia200x jia200x commented May 3, 2021

Contribution description

This PR fixes the invocation of 11-lorawan. The keys were renamed in RIOT-OS/Release-Specs#201, so the current keys are not applied. Therefore the test fails.

This probably needs backport.

Testing procedure

Please check the variables match the ones exposed in RIOT-OS/Release-Specs#201. We should also trigger this tests from GH Actions.

Issues/PRs references

RIOT-OS/Release-Specs#201

@jia200x jia200x requested review from miri64 and fjmolinas May 3, 2021 12:57
@miri64 miri64 added Area: CI Area: Continuous Integration of RIOT components CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) labels May 3, 2021
@miri64 miri64 force-pushed the pr/fix_gnrc_lorawan_wf branch from fa6d7ed to 985515b Compare May 3, 2021 13:45
@miri64
Copy link
Member

miri64 commented May 3, 2021

@jia200x could you start a run with your PR in your fork, with the branch of this PR both for "Use workflow from" and "RIOT version to checkout"? I added a filter, so only spec11 is run.

@miri64
Copy link
Member

miri64 commented May 3, 2021

@jia200x could you start a run with your PR in your fork, with the branch of this PR both for "Use workflow from" and "RIOT version to checkout"? I added a filter, so only spec11 is run.

See #16432 for how to not have this required in the future.

@miri64
Copy link
Member

miri64 commented May 4, 2021

@jia200x could you start a run with your PR in your fork, with the branch of this PR both for "Use workflow from" and "RIOT version to checkout"? I added a filter, so only spec11 is run.

See #16432 for how to not have this required in the future.

#16432 got merged so I started a test over at #16430.

@miri64
Copy link
Member

miri64 commented May 4, 2021

Arghs won't work... since this PR also changes the release-tests :-/... Let's just merge this and test then!

@miri64 miri64 force-pushed the pr/fix_gnrc_lorawan_wf branch from fa6d7ed to 985515b Compare May 4, 2021 09:50
@miri64 miri64 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label May 4, 2021
Copy link
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@miri64 miri64 merged commit c044622 into RIOT-OS:master May 4, 2021
@miri64
Copy link
Member

miri64 commented May 4, 2021

Test suite is running here.

@miri64
Copy link
Member

miri64 commented May 4, 2021

There is a hard fault now when trying to fetch the interface in 11.5, but this has nothing to do with the scope of this PR. I will report it in the current release tracking issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: CI Area: Continuous Integration of RIOT components CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants