-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh_workflows: adapt to GNRC LoRaWAN Release Test env variables #16430
Conversation
fa6d7ed
to
985515b
Compare
@jia200x could you start a run with your PR in your fork, with the branch of this PR both for "Use workflow from" and "RIOT version to checkout"? I added a filter, so only |
Arghs won't work... since this PR also changes the release-tests :-/... Let's just merge this and test then! |
fa6d7ed
to
985515b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
Test suite is running here. |
There is a hard fault now when trying to fetch the interface in 11.5, but this has nothing to do with the scope of this PR. I will report it in the current release tracking issue. |
Contribution description
This PR fixes the invocation of
11-lorawan
. The keys were renamed in RIOT-OS/Release-Specs#201, so the current keys are not applied. Therefore the test fails.This probably needs backport.
Testing procedure
Please check the variables match the ones exposed in RIOT-OS/Release-Specs#201. We should also trigger this tests from GH Actions.
Issues/PRs references
RIOT-OS/Release-Specs#201