Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnrc_tcp: align with sock tcp #16493

Merged
merged 1 commit into from
Jul 13, 2021
Merged

gnrc_tcp: align with sock tcp #16493

merged 1 commit into from
Jul 13, 2021

Conversation

brummer-simon
Copy link
Member

Contribution description

This PR implements all missing functions and API changes for SOCK_TCP integration to GNRC_TCP.

Testing procedure

All new functions and return codes are tested within the GNRC_TCP suite.
Just execute the tests under tests/gnrc_tcp

Issues/PRs references

Depends on PR #16459
Depends on PR #16461
Fixes #10664 - TCP Sockets can not be used / built

@github-actions github-actions bot added Area: network Area: Networking Area: sys Area: System Area: tests Area: tests and testing framework labels May 22, 2021
@brummer-simon brummer-simon mentioned this pull request May 22, 2021
Merged
@MrKevinWeiss MrKevinWeiss added this to the Release 2021.07 milestone Jun 21, 2021
@brummer-simon brummer-simon force-pushed the gnrc_tcp-align_with_sock_tcp branch from 34cf5e1 to 3dc23a7 Compare July 2, 2021 08:03
@github-actions github-actions bot added the Area: doc Area: Documentation label Jul 2, 2021
@benpicco benpicco added the State: waiting for other PR State: The PR requires another PR to be merged first label Jul 8, 2021
@brummer-simon brummer-simon mentioned this pull request Jul 8, 2021
Merged
@brummer-simon brummer-simon force-pushed the gnrc_tcp-align_with_sock_tcp branch from 3dc23a7 to 6e6a341 Compare July 8, 2021 15:23
@benpicco benpicco removed the State: waiting for other PR State: The PR requires another PR to be merged first label Jul 13, 2021
benpicco
benpicco reviewed Jul 13, 2021
View reviewed changes
Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks quite reasonable - please rebase

@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jul 13, 2021
@brummer-simon brummer-simon force-pushed the gnrc_tcp-align_with_sock_tcp branch from 6e6a341 to 873d1fe Compare July 13, 2021 18:33
@github-actions github-actions bot removed the Area: doc Area: Documentation label Jul 13, 2021
@brummer-simon
Copy link
Member Author

Done

benpicco
benpicco approved these changes Jul 13, 2021
View reviewed changes
Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only adds getters and tests are still passing.

@benpicco benpicco merged commit 602384e into RIOT-OS:master Jul 13, 2021
@MrKevinWeiss MrKevinWeiss removed this from the Release 2021.07 milestone Jul 15, 2021
@benpicco benpicco added this to the Release 2021.10 milestone Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

@cgundogan cgundogan Awaiting requested review from cgundogan

@haukepetersen haukepetersen Awaiting requested review from haukepetersen

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

@PeterKietzmann PeterKietzmann Awaiting requested review from PeterKietzmann PeterKietzmann is a code owner

Assignees
No one assigned
Labels
Area: network Area: Networking Area: sys Area: System Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Milestone
Release 2021.10
Development

Successfully merging this pull request may close these issues.

TCP Sockets can not be used / built
3 participants
@brummer-simon @benpicco @MrKevinWeiss