Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dist/tools/pyterm: ipv6 address support for tcp_serial option #16726

Merged
merged 1 commit into from
Aug 14, 2021

Conversation

hugueslarrive
Copy link
Contributor

Contribution description

Trying to connect to telnet server module with pyterm:

$ ./dist/tools/pyterm/pyterm -ts [fe80::a413:5bff:feac:60b0%enp0s25]:23
Twisted not available, please install it if you want to use pyterm's JSON capabilities
2021-08-12 22:31:02,270 # Connect to [fe80:
2021-08-12 22:31:02,274 # [Errno -2] Name or service not known
2021-08-12 22:31:02,275 # Something went wrong connecting to localhost:[fe80::a413:5bff:feac:60b0%enp0s25]:23

Testing procedure

$ ./dist/tools/pyterm/pyterm -ts [fe80::a413:5bff:feac:60b0%enp0s25]:23
Twisted not available, please install it if you want to use pyterm's JSON capabilities
2021-08-12 22:38:26,894 # Connect to fe80::a413:5bff:feac:60b0%enp0s25:23
Welcome to pyterm!
Type '/exit' to exit.
version
2021-08-12 22:38:32,398 # version
2021-08-12 22:38:32,449 # 2014.01-34120-g69dde-gnrc_sock_tcp-telnet
>

Issues/PRs references

See also #16723

@github-actions github-actions bot added the Area: tools Area: Supplementary tools label Aug 12, 2021
@benpicco benpicco requested review from miri64 and OlegHahm August 12, 2021 21:14
@benpicco benpicco added CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation labels Aug 12, 2021
Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Aug 12, 2021
@benpicco benpicco merged commit ce99933 into RIOT-OS:master Aug 14, 2021
@benpicco benpicco added this to the Release 2021.10 milestone Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants