Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.murdock: Add same54-xpro to kconfig tests #17255

Merged
merged 7 commits into from
Nov 29, 2021
Merged

.murdock: Add same54-xpro to kconfig tests #17255

merged 7 commits into from
Nov 29, 2021

Conversation

MrKevinWeiss
Copy link
Contributor

@MrKevinWeiss MrKevinWeiss commented Nov 23, 2021 •
edited
Loading

Contribution description

  • Add same5x cpu to kconfig tests via the same54-xpro board.
  • Fix and apply mtd_spi_nor kconfig modelling on all affected boards
  • Add mtd make dependency modelling to avr-rss2 via at24mac module as it contains chip on the board
  • Kconfig model the MODULE_PERIPH_GPIO_TAMPER_WAKE
  • Kconfig model the MODULE_PERIPH_SPI_ON_QSPI

Testing procedure

CI passes

Issues/PRs references

Related to #16875

@MrKevinWeiss MrKevinWeiss added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 23, 2021
@github-actions github-actions bot added the Area: CI Area: Continuous Integration of RIOT components label Nov 23, 2021
@MrKevinWeiss MrKevinWeiss changed the title just a test .murdock: Add same54-xpro to kconfig tests Nov 23, 2021
@MrKevinWeiss MrKevinWeiss mentioned this pull request Nov 23, 2021
Closed
@github-actions github-actions bot added Area: boards Area: Board ports Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration Area: tests Area: tests and testing framework Area: cpu Area: CPU/MCU ports Platform: ARM Platform: This PR/issue effects ARM-based platforms labels Nov 24, 2021
@MrKevinWeiss
Copy link
Contributor Author

Just so this is documented somewhere:

Currently the same54-xpro board has 2 mdt based interfaces, the spi_nor and the at24mac... This should be described by the board somehow but maybe abstracting the a HAVE_ is not the best way since , only for this board we need to select the spi_on_qspi for the spi_nor. With an abstracted HAVE_MTD_SPI_NOR this should normally bring in just the periph_spi but not all boards will need this extra condition.

benpicco
benpicco reviewed Nov 24, 2021
View reviewed changes
drivers/periph_common/Kconfig.gpio Outdated Show resolved Hide resolved
drivers/periph_common/Kconfig.gpio Show resolved Hide resolved
drivers/periph_common/Kconfig.gpio Outdated Show resolved Hide resolved
drivers/periph_common/Kconfig.spi Outdated Show resolved Hide resolved
drivers/periph_common/Kconfig.spi Outdated Show resolved Hide resolved
@MrKevinWeiss
Copy link
Contributor Author

Thanks for the review @benpicco I adapted your changes and hopefully cleared up the MODULE_PERIPH_INIT_SPI_ON_QSPI issue.

I also fixed the structure of the mtd and eui by resolving them in the modules based on the HAVE_ convention. The only module selection that occurs in the board is based on a peripheral specific configuration, similar to the LPUART stuff needed for selection STDIO.

@github-actions github-actions bot added the Area: build system Area: Build system label Nov 25, 2021
@MrKevinWeiss
Copy link
Contributor Author

rebased to fix the atmac conflict thing. Also running the whole test suite to see if I broke other things.

@MrKevinWeiss
Copy link
Contributor Author

doh, I didn't test the right board... Working on it

@MrKevinWeiss
Copy link
Contributor Author

Things we getting a bit hairy so a rebased and squashed.

This PR will only add the missing modules needed for the same54-xpro board, add the same54-xpro board, and apply the missing modules to any affected boards. This does not mean the the additional boards will be working just that modules added are correctly applied.

That being said, the adafruit-itsybitsy-m4adafruit-itsybitsy-m4 still has some missing modules (something with the USB) and is not being added to the list yet but will be done later.

MrKevinWeiss
MrKevinWeiss commented Nov 26, 2021
View reviewed changes
cpu/samd5x/Kconfig Outdated
@@ -17,6 +17,7 @@ config CPU_COMMON_SAMD5X
select HAS_PERIPH_HWRNG
select HAS_PERIPH_RTC_MEM
select HAS_PERIPH_SPI_ON_QSPI
select MODULE_PERIPH_RTC_RTT if MODULE_PERIPH_GPIO_TAMPER_WAKE
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmmm I am not actually too happy with this.

@MrKevinWeiss MrKevinWeiss added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Nov 26, 2021
@benpicco
Copy link
Contributor

Looks good from my side, feel free to squash

@MrKevinWeiss
Copy link
Contributor Author

Done! Should we try the automerge?

@MrKevinWeiss MrKevinWeiss added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Nov 29, 2021
@MrKevinWeiss
Copy link
Contributor Author

seems like some memory was full in the CI, rerunning.

@benpicco benpicco enabled auto-merge November 29, 2021 18:11
@benpicco benpicco merged commit 05b9c84 into RIOT-OS:master Nov 29, 2021
@MrKevinWeiss MrKevinWeiss deleted the pr/kconfig/sam54 branch November 30, 2021 07:39
@MrKevinWeiss
Copy link
Contributor Author

Thanks!

@fjmolinas fjmolinas added this to the Release 2022.01 milestone Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

@kaspar030 kaspar030 Awaiting requested review from kaspar030 kaspar030 is a code owner

@cgundogan cgundogan Awaiting requested review from cgundogan

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

Assignees
No one assigned
Labels
Area: boards Area: Board ports Area: build system Area: Build system Area: CI Area: Continuous Integration of RIOT components Area: cpu Area: CPU/MCU ports Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms
Projects
None yet
Milestone
Release 2022.01
Development

Successfully merging this pull request may close these issues.
4 participants
@MrKevinWeiss @benpicco @leandrolanzieri @fjmolinas