Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards/adafruit-itsybitsy-m4: Model kconfig #17331

Merged
merged 4 commits into from
Dec 6, 2021
Merged

boards/adafruit-itsybitsy-m4: Model kconfig #17331

merged 4 commits into from
Dec 6, 2021

Conversation

MrKevinWeiss
Copy link
Contributor

Contribution description

This models Kconfig for the samd5x based board adafruit-itsybitsy-m4.

It also adds boards_common_samdx1-arduino-bootloader and usb_board_reset.

Testing procedure

Check the Kconfig changes and modelling
Green CI

Issues/PRs references

Part of #16875

@MrKevinWeiss MrKevinWeiss added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Dec 3, 2021
@github-actions github-actions bot added Area: boards Area: Board ports Area: CI Area: Continuous Integration of RIOT components Area: Kconfig Area: Kconfig integration Area: sys Area: System labels Dec 3, 2021
@MrKevinWeiss
Copy link
Contributor Author

Using murdock to check all apps for the board.

@MrKevinWeiss MrKevinWeiss mentioned this pull request Dec 3, 2021
Closed
leandrolanzieri
leandrolanzieri reviewed Dec 3, 2021
View reviewed changes
sys/usb_board_reset/Kconfig Show resolved Hide resolved
boards/adafruit-itsybitsy-m4/Kconfig Outdated Show resolved Hide resolved
boards/adafruit-itsybitsy-m4/Kconfig Outdated Show resolved Hide resolved
@MrKevinWeiss MrKevinWeiss force-pushed the pr/kconfig/samd5x branch 2 times, most recently from 9114cbb to 010fa54 Compare December 3, 2021 22:43
@MrKevinWeiss
Copy link
Contributor Author

Lets see what murdock says

@leandrolanzieri
Copy link
Contributor

Lets see what murdock says

Looks like it agrees. Please squash @MrKevinWeiss

@MrKevinWeiss
Copy link
Contributor Author

Hmmm looks like I did (auto-merge? 😄 )

leandrolanzieri
leandrolanzieri approved these changes Dec 6, 2021
View reviewed changes
Copy link
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@leandrolanzieri leandrolanzieri added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels Dec 6, 2021
@leandrolanzieri leandrolanzieri added this to the Release 2022.01 milestone Dec 6, 2021
@leandrolanzieri leandrolanzieri merged commit 4f51174 into RIOT-OS:master Dec 6, 2021
@MrKevinWeiss MrKevinWeiss deleted the pr/kconfig/samd5x branch December 6, 2021 09:38
@MrKevinWeiss
Copy link
Contributor Author

Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco left review comments

@leandrolanzieri leandrolanzieri leandrolanzieri approved these changes

@cgundogan cgundogan Awaiting requested review from cgundogan

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@kaspar030 kaspar030 Awaiting requested review from kaspar030 kaspar030 is a code owner

Assignees
No one assigned
Labels
Area: boards Area: Board ports Area: CI Area: Continuous Integration of RIOT components Area: Kconfig Area: Kconfig integration Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines
Projects
None yet
Milestone
Release 2022.01
Development

Successfully merging this pull request may close these issues.
3 participants
@MrKevinWeiss @leandrolanzieri @benpicco