sys/net/nanocoap: allow for zero-copy payload response #17559
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benpicco
requested review from
aabadie,
cgundogan,
fjmolinas,
haukepetersen,
leandrolanzieri,
maribu,
MichelRottleuthner,
miri64,
PeterKietzmann and
smlng
as code owners
benpicco
added
State: demonstrator
github-actions
bot
added
the
Area: CoAP
github-actions
bot
added
Area: examples
2 tasks
|
superseded by #17958 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
We don't want to copy the payload into a separate buffer together with the CoAP header when sending.
Instead make use of
sock_udp_sendv()and use two packet snips, one for the header and one for the payload.Testing procedure
examples/nanocoap_serverstill works, but now the response to "/riot/board" is no longer copied into the reply buffer, but just referenced.Issues/PRs references
depends on and inludes
#17544
#17485