gnrc_sock: warn about non-zero receive timeouts with sock_async #17691
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
It took me nearly a day of debugging to find out that my event queue was broken due to the handler thread being stuck in a
sock_udp_recv()
. To prevent that in the future, issue a warning about non-zero-timeouts when the asynchronous callback is set.Testing procedure
Apply the following patch:
Running
make -C tests/gnrc_sock_async_event/ -j flash test
for any platform should include the warning in the outputIt should not show up without the change.
Issues/PRs references