Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{examples,tests}/rust: cargo update and deprecation fixes #17704

Merged
merged 2 commits into from
Feb 25, 2022

Conversation

chrysn
Copy link
Member

@chrysn chrysn commented Feb 25, 2022

Contribution description

This restores compatibility with current nightlies by using the latest
coap-message version (after a nightly-only feature that uses saw a late
change), and also removes obstacles for use with stable Rust 1.59 (in
unrelated parts; the CoAP example is still nightly-only).

In addition, two deprecations in the used libraries are followed to ensure a warning-free output.

Testing procedure

  • Green CI
  • In addition, I did make -C tests/run_minimal all flash test on native and microbit-v2, as well as a native test run on the gcoap example. (Both with latest nightly and with BUILD_IN_DOCKER=1)

Issues/PRs references

Contributes-To: #17526

This restores compatibility with current nightlies by using the latest
coap-message version (after a nightly-only feature that uses saw a late
change), and also removes obstacles for use with stable Rust 1.59 (in
unrelated parts; the CoAP example is still nightly-only).

Contributes-To: RIOT-OS#17526
@chrysn chrysn added Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: examples Area: Example Applications Area: Rust Area: Rust wrapper labels Feb 25, 2022
@github-actions github-actions bot added the Area: tests Area: tests and testing framework label Feb 25, 2022
Copy link
Contributor

@kaspar030 kaspar030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, trusting CI.

@chrysn chrysn enabled auto-merge February 25, 2022 12:24
@chrysn chrysn disabled auto-merge February 25, 2022 12:24
@chrysn chrysn enabled auto-merge February 25, 2022 12:25
@chrysn chrysn changed the title {examples,tests}/rust: cargo update {examples,tests}/rust: cargo update and deprecation fixes Feb 25, 2022
@chrysn chrysn mentioned this pull request Feb 25, 2022
2 tasks
@chrysn chrysn merged commit 039e993 into RIOT-OS:master Feb 25, 2022
@chrysn chrysn deleted the rust-wrappers-update branch February 25, 2022 14:04
@OlegHahm OlegHahm added this to the Release 2022.04 milestone Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: examples Area: Example Applications Area: Rust Area: Rust wrapper Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants