Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: move riot_logo.h to tests base directory #17917

Merged
merged 3 commits into from
Apr 13, 2022
Merged

tests: move riot_logo.h to tests base directory #17917

merged 3 commits into from
Apr 13, 2022

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented Apr 12, 2022

Contribution description

This removes all duplicated versions of this file in the test application related to display feature.

Testing procedure

A green CI should be enough. The file is the same for all related test applications.

Issues/PRs references

Waiting for #16176

@aabadie aabadie added the State: waiting for other PR State: The PR requires another PR to be merged first label Apr 12, 2022
@github-actions github-actions bot added Area: boards Area: Board ports Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration Area: pkg Area: External package ports Area: sys Area: System Area: tests Area: tests and testing framework labels Apr 12, 2022
@aabadie
Copy link
Contributor Author

aabadie commented Apr 12, 2022

Also added a couple of commits to improve the position of the logo (centered independent of the size of the screen).

@aabadie aabadie force-pushed the pr/tests/common-riot-logo branch from c90fe15 to 809d3d9 Compare April 13, 2022 06:00
@aabadie aabadie removed the State: waiting for other PR State: The PR requires another PR to be merged first label Apr 13, 2022
@github-actions github-actions bot removed Area: pkg Area: External package ports Area: Kconfig Area: Kconfig integration Area: drivers Area: Device drivers Area: sys Area: System Area: boards Area: Board ports labels Apr 13, 2022
@aabadie aabadie force-pushed the pr/tests/common-riot-logo branch from 809d3d9 to d5beea3 Compare April 13, 2022 06:01
@aabadie aabadie added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Apr 13, 2022
fjmolinas
fjmolinas approved these changes Apr 13, 2022
View reviewed changes
Copy link
Contributor

@fjmolinas fjmolinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good cleanup!

@aabadie aabadie merged commit 2bd608a into RIOT-OS:master Apr 13, 2022
@aabadie aabadie deleted the pr/tests/common-riot-logo branch April 13, 2022 10:28
@chrysn chrysn added this to the Release 2022.07 milestone Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjmolinas fjmolinas fjmolinas approved these changes

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@jia200x jia200x Awaiting requested review from jia200x

@cgundogan cgundogan Awaiting requested review from cgundogan

@smlng smlng Awaiting requested review from smlng

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@gschorcht gschorcht Awaiting requested review from gschorcht

Assignees
No one assigned
Labels
Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Milestone
Release 2022.07
Development

Successfully merging this pull request may close these issues.
3 participants
@aabadie @fjmolinas @chrysn