Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers/disp_dev: use struct to store display area coordinates #17921

Merged
merged 5 commits into from
Apr 19, 2022
Merged

drivers/disp_dev: use struct to store display area coordinates #17921

merged 5 commits into from
Apr 19, 2022

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented Apr 12, 2022

Contribution description

This PR is a take over of #14051 to only update the disp_dev API. Since now there are new modules that implements an adapter to this API (STM32 LTDC periph, LCD common drivers) and several users (lvgl packages, tests/disp_dev and tests/pkg_qr-code-generator).

This PR also contains small improvements compared to #14051:

  • make input the parameter const
  • call it disp_dev_area_t to better reflects what it is about

Compared to master this PR increases the ROM size by 16B (checked by compiling tests/disp_dev for the adafruit-clue board).
I guess that this is acceptable.

Testing procedure

  • Green Murdock
  • tests/disp_dev, tests/pkg_lvgl and tests/pkg_qr-code-generator are still working

Issues/PRs references

Closes #14051, depends on #16176

@github-actions github-actions bot added Area: boards Area: Board ports Area: cpu Area: CPU/MCU ports Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration Area: pkg Area: External package ports Area: sys Area: System Area: tests Area: tests and testing framework Platform: ARM Platform: This PR/issue effects ARM-based platforms labels Apr 12, 2022
@aabadie aabadie added Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care. State: waiting for other PR State: The PR requires another PR to be merged first and removed State: waiting for other PR State: The PR requires another PR to be merged first labels Apr 12, 2022
@aabadie aabadie force-pushed the pr/drivers/disp_dev_coordinates branch from 7a2ca15 to ea2c571 Compare April 13, 2022 06:02
@github-actions github-actions bot removed Area: boards Area: Board ports Area: sys Area: System Area: Kconfig Area: Kconfig integration labels Apr 13, 2022
@aabadie aabadie added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Apr 13, 2022
@aabadie aabadie force-pushed the pr/drivers/disp_dev_coordinates branch from ea2c571 to a16449f Compare April 13, 2022 10:52
@aabadie aabadie added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Apr 13, 2022
@benpicco benpicco added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Apr 13, 2022
fjmolinas
fjmolinas approved these changes Apr 19, 2022
View reviewed changes
Copy link
Contributor

@fjmolinas fjmolinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@aabadie aabadie merged commit 63b2548 into RIOT-OS:master Apr 19, 2022
@aabadie aabadie deleted the pr/drivers/disp_dev_coordinates branch April 19, 2022 10:48
@aabadie
Copy link
Contributor Author

aabadie commented Apr 19, 2022

Thanks!

@chrysn chrysn added this to the Release 2022.07 milestone Aug 25, 2022
@aabadie aabadie mentioned this pull request Jul 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjmolinas fjmolinas fjmolinas approved these changes

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@jia200x jia200x Awaiting requested review from jia200x

@cgundogan cgundogan Awaiting requested review from cgundogan

@smlng smlng Awaiting requested review from smlng

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@DipSwitch DipSwitch Awaiting requested review from DipSwitch

@vincent-d vincent-d Awaiting requested review from vincent-d vincent-d is a code owner

@gschorcht gschorcht Awaiting requested review from gschorcht

Assignees
No one assigned
Labels
Area: cpu Area: CPU/MCU ports Area: drivers Area: Device drivers Area: pkg Area: External package ports Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care.
Projects
None yet
Milestone
Release 2022.07
Development

Successfully merging this pull request may close these issues.
4 participants
@aabadie @fjmolinas @chrysn @benpicco