sys/suit: avoid installing payload twice

[fjmolinas]

Contribution description

For some reason the generated manifest triggers the payload to be installed twice:

SUIT policy checks OK.
Formatted component name: .ram.0
Fetching firmware |█████████████████████████| 100%
Finalizing payload store
Verifying image digest
Starting digest verification against image
Install correct payload
Verifying image digest
Starting digest verification against image
Install correct payload

Why I'm not sure is whether this is an issue in the manifest generation or if it's something to handle in code. Pinging @bergzand on this.

Testing procedure

Run examples/suit_update payload is installed once:

SUIT policy check OK.
Formatted component name: .ram.0
Fetching firmware |█████████████████████████| 100%
Finalizing payload store
Verifying image digest
Starting digest verification against image
Install correct payload

[fjmolinas]

For context this is called twice because in the manifest there are actually two condition-image-match:

RIOT/dist/tools/suit/suit-manifest-generator/suit_tool/compile.py

Line 337 in a427d63

ValidateSeq.append(mkCommand(cid, 'condition-image-match', None))

RIOT/dist/tools/suit/suit-manifest-generator/suit_tool/compile.py

Line 283 in a427d63

InstSeq.append(mkCommand(cid, 'condition-image-match', None))

Which in turn results in multiple calls to _dtv_verify_image_match which does the install/verify

[fjmolinas]

I removed setting the SUIT_COMPONENT_STATE_FINALIZED flag since this stage does not necessarily mean that it's finalized since there is actually a suit-validate sequence called after the suit-install sequence. I find it somewhat redundant when the install sequence already implements the condition-image-match, but since the validate sequence is mandatory, I would think it just means that the extra condition-image-match could be removed from install.

[fjmolinas]

Note that my main motivation for this is to know when from a user perspective I can consider the payload "ready to use", and I would have thought that once installed if it succeeded then it should be good to go.

[bergzand]

Ack, thanks for the fix

[fjmolinas]

Thanks!