Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/cmsis-nn: model in Kconfig #17997

Merged
merged 2 commits into from
Apr 26, 2022
Merged

pkg/cmsis-nn: model in Kconfig #17997

merged 2 commits into from
Apr 26, 2022

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented Apr 25, 2022

Contribution description

As the title says.

I had to rework a bit the internal modules of the packages because of mixed uppercase and lowercase letters in the module names.

Testing procedure

Green Murdock

Issues/PRs references

None

@github-actions github-actions bot added Area: Kconfig Area: Kconfig integration Area: pkg Area: External package ports Area: tests Area: tests and testing framework labels Apr 25, 2022
@aabadie aabadie added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Apr 25, 2022
@aabadie aabadie mentioned this pull request Apr 25, 2022
Merged
MrKevinWeiss
MrKevinWeiss approved these changes Apr 26, 2022
View reviewed changes
Copy link
Contributor

@MrKevinWeiss MrKevinWeiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like circleci has some issue with pulling from docker... Maybe dockerhub it was down. As murdock is green and things look good I ACK.

@aabadie aabadie merged commit e2900ac into RIOT-OS:master Apr 26, 2022
@aabadie aabadie deleted the pr/tests/pkg_cmsis_nn_kconfig branch April 26, 2022 07:23
@chrysn chrysn added this to the Release 2022.07 milestone Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrKevinWeiss MrKevinWeiss MrKevinWeiss approved these changes

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@cgundogan cgundogan Awaiting requested review from cgundogan

@smlng smlng Awaiting requested review from smlng

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

Assignees
No one assigned
Labels
Area: Kconfig Area: Kconfig integration Area: pkg Area: External package ports Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Milestone
Release 2022.07
Development

Successfully merging this pull request may close these issues.
3 participants
@aabadie @MrKevinWeiss @chrysn