Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/pkg.mk: silence info if QUIETER #18031

Merged
merged 4 commits into from
Jun 9, 2022
Merged

pkg/pkg.mk: silence info if QUIETER #18031

merged 4 commits into from
Jun 9, 2022

Conversation

fjmolinas
Copy link
Contributor

@fjmolinas fjmolinas commented Apr 28, 2022 •
edited
Loading

Contribution description

Silence most pkg clonning/handling related logs when QUIETER is set.

For some reason event though --quiet is passed I still get the progress report:

Building application "tests_pkg_edhoc_c" for "native" with MCU "native".

2022-04-28 14:07:29 URL:https://www.dlbeer.co.nz/downloads/c25519-2017-10-05.zip [68419/68419] -> "/home/francisco/workspace/RIOT/build/pkg/c25519-2017-10-05.zip" [1]
remote: Enumerating objects: 111, done.
remote: Counting objects: 100% (111/111), done.
remote: Compressing objects: 100% (103/103), done.
remote: Total 111 (delta 14), reused 71 (delta 7), pack-reused 0
Receiving objects: 100% (111/111), 188.56 KiB | 3.85 MiB/s, done.
Resolving deltas: 100% (14/14), done.
remote: Enumerating objects: 27, done.
remote: Counting objects: 100% (27/27), done.
remote: Compressing objects: 100% (23/23), done.
remote: Total 27 (delta 0), reused 12 (delta 0), pack-reused 0
Receiving objects: 100% (27/27), 24.35 KiB | 24.35 MiB/s, done.
remote: Enumerating objects: 55, done.
remote: Counting objects: 100% (55/55), done.
remote: Compressing objects: 100% (53/53), done.
remote: Total 55 (delta 14), reused 6 (delta 0), pack-reused 0
Receiving objects: 100% (55/55), 694.12 KiB | 4.34 MiB/s, done.
Resolving deltas: 100% (14/14), done.
   text	   data	    bss	    dec	    hex	filename
 258985	   1460	 169800	 430245	  690a5	/home/francisco/workspace/RIOT/tests/pkg_edhoc_c/bin/native/tests_pkg_edhoc_c.elf

So I redirected the output so it does not see a tty, now it's completely silent.

RIOT_CI_BUILD=1 make -C tests/pkg_nanocbor/
Building application "tests_pkg_nanocbor" for "native" with MCU "native".
   text    data     bss     dec     hex filename
  36388     721   47884   84993   14c01 /home/francisco/workspace/RIOT/tests/pkg_nanocbor/bin/native/tests_pkg_nanocbor.elf

Not sure if this is a bug with my git version or I'm missing something?

Testing procedure

Build an application with RIOT_CI_BUILD, it should be much more silent now.

@fjmolinas fjmolinas requested review from kfessel and kaspar030 April 28, 2022 12:14
@github-actions github-actions bot added Area: build system Area: Build system Area: pkg Area: External package ports labels Apr 28, 2022
aabadie
aabadie reviewed Jun 1, 2022
View reviewed changes
makefiles/vars.inc.mk Outdated Show resolved Hide resolved
@fjmolinas fjmolinas added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jun 1, 2022
@fjmolinas
Copy link
Contributor Author

Found a workaround, now it's really silent.

@fjmolinas fjmolinas removed the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jun 1, 2022
@fjmolinas
Copy link
Contributor Author

Oh I broke something

@fjmolinas
Copy link
Contributor Author

Oh I broke something

fixed I think

@fjmolinas fjmolinas added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jun 1, 2022
@maribu
Copy link
Member

maribu commented Jun 1, 2022

The instance of hash mismatch seems to be not the typical flash positive this time. The binaries have also a different size :/

@fjmolinas fjmolinas added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jun 2, 2022
@fjmolinas
Copy link
Contributor Author

The instance of hash mismatch seems to be not the typical flash positive this time. The binaries have also a different size :/

Hmm I'm not sure, since after a new build It's a different application that failed, seems like the classic false positive to me.

@fjmolinas
Copy link
Contributor Author

Anything remaining here?

@fjmolinas fjmolinas added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jun 8, 2022
maribu
maribu approved these changes Jun 9, 2022
View reviewed changes
Copy link
Member

@maribu maribu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Trusting your and Murdock's testing.

@aabadie aabadie merged commit c239f63 into RIOT-OS:master Jun 9, 2022
@fjmolinas
Copy link
Contributor Author

Thanks for the review!

@fjmolinas fjmolinas deleted the pr_pkg_quieter branch June 9, 2022 09:37
@chrysn chrysn added this to the Release 2022.07 milestone Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aabadie aabadie aabadie left review comments

@maribu maribu maribu approved these changes

@kfessel kfessel Awaiting requested review from kfessel

@kaspar030 kaspar030 Awaiting requested review from kaspar030

Assignees
No one assigned
Labels
Area: build system Area: Build system Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Milestone
Release 2022.07
Development

Successfully merging this pull request may close these issues.
4 participants
@fjmolinas @maribu @aabadie @chrysn