Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build system: no periph_init for periph_gpio_ll* #18132

Merged
merged 1 commit into from
May 25, 2022
Merged

build system: no periph_init for periph_gpio_ll* #18132

merged 1 commit into from
May 25, 2022

Conversation

maribu
Copy link
Member

@maribu maribu commented May 24, 2022

Contribution description

None of the periph_gpio_ll* features provides or requires a periph_init hook. Hence, blacklist them for periph_init conversion.

Testing procedure

E.g. run $ make BOARD=nucleo-f767zi info-modules -C tests/periph_gpio_ll/ | grep gpio_ll.

In addition, this should not change binaries in any way.

Result on master:

$ make BOARD=nucleo-f767zi info-modules -C tests/periph_gpio_ll/ | grep gpio_ll
make: Entering directory '/home/maribu/Repos/software/RIOT/tests/periph_gpio_ll'
periph_gpio_ll
periph_gpio_ll_irq
periph_gpio_ll_irq_level_triggered_high
periph_gpio_ll_irq_level_triggered_low
periph_init_gpio_ll
periph_init_gpio_ll_irq
periph_init_gpio_ll_irq_level_triggered_high
periph_init_gpio_ll_irq_level_triggered_low
make: Leaving directory '/home/maribu/Repos/software/RIOT/tests/periph_gpio_ll'

Result with this PR

$ make BOARD=nucleo-f767zi info-modules -C tests/periph_gpio_ll/ | grep gpio_ll
make: Entering directory '/home/maribu/Repos/software/RIOT/tests/periph_gpio_ll'
periph_gpio_ll
periph_gpio_ll_irq
periph_gpio_ll_irq_level_triggered_high
periph_gpio_ll_irq_level_triggered_low
make: Leaving directory '/home/maribu/Repos/software/RIOT/tests/periph_gpio_ll'

Issues/PRs references

None

@maribu
build system: no periph_init for periph_gpio_ll*
dc47528 
None of the periph_gpio_ll* features provides or requires a periph_init
hook. Hence, blacklist them for periph_init conversion.
@github-actions github-actions bot added the Area: build system Area: Build system label May 24, 2022
@maribu maribu added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels May 24, 2022
@maribu maribu enabled auto-merge May 24, 2022 16:16
@benpicco benpicco added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels May 24, 2022
@maribu maribu merged commit e79965e into RIOT-OS:master May 25, 2022
@maribu maribu deleted the makefiles/features_modules.inc.mk branch June 2, 2022 19:38
@chrysn chrysn added this to the Release 2022.07 milestone Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

Assignees
No one assigned
Labels
Area: build system Area: Build system CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2022.07
Development

Successfully merging this pull request may close these issues.
3 participants
@maribu @benpicco @chrysn