Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers/st7735/kconfig: add hardware feature symbol #18135

Conversation

leandrolanzieri
Copy link
Contributor

Contribution description

In #17903 the st7735 feature was selected, but the symbol was actually not defined. Seems to be the cause for the current failures in the nightlies CI run.

Testing procedure

  • Green CI
  • Compare that the list of modules with and without Kconfig

Issues/PRs references

#17903

@leandrolanzieri leandrolanzieri added the Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) label May 24, 2022
@leandrolanzieri leandrolanzieri added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label May 24, 2022
@github-actions github-actions bot added Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration labels May 24, 2022
@leandrolanzieri leandrolanzieri merged commit 95716d4 into RIOT-OS:master May 25, 2022
@leandrolanzieri leandrolanzieri deleted the pr/driver/st7735/kconfig_add_feature branch May 25, 2022 15:31
@chrysn chrysn added this to the Release 2022.07 milestone Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants