cpu/esp: add compilation tests for optional ESP modules #18158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gschorcht
requested review from
smlng,
leandrolanzieri,
aabadie,
MichelRottleuthner and
fjmolinas
as code owners
github-actions
bot
added
Area: examples
gschorcht
added
Platform: ESP
benpicco
approved these changes
Jun 2, 2022
fjmolinas
added
CI: ready for build
gschorcht
changed the title
|
The python-tests failure was fixed by #18160, please rebase |
Add `esp32-ci` and `esp8266-ci` as external boards to cover optional modules by CI compilation: - examples/gnrc_networking to cover ESP32/ESP8266 `esp_wifi_ap` - examples/gnrc_minimal to cover ESP32 `esp_wifi_enterprise`
Add `esp32-ci` and `esp8266-ci` as external boards to cover optional module `esp_hw_counter` (ESP32) and `esp_sw_timer` (ESP8266) by CI compilation.
gschorcht
added
CI: skip compile test
gschorcht
force-pushed
the
cpu/esp/add_compilation_tests_optional_modules
branch
from
3cbfd5c to
e496dd8
Compare
github-actions
bot
removed
Platform: ESP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR adds
esp32-ciandesp8266-cias external boards to following tests/examples to cover all optional modules by CI compilation:tests/periph_timerto compileesp_hw_counter(ESP32)tests/periph_timerto compileesp_sw_timer(ESP8266)examples/gnrc_networkingto compileesp_wifi_ap(ESP32 and ESP8266)examples/gnrc_minimalto compileesp_wifi_enterprise(ESP32)Testing procedure
Green CI
Issues/PRs references
Missing compilations were found in PR #17601 (comment)