sys/fmt: fix output on native #18186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maribu
requested review from
miri64,
haukepetersen,
PeterKietzmann,
cgundogan and
kaspar030
as code owners
benpicco
reviewed
Jun 9, 2022
benpicco
added
CI: ready for build
maribu
requested review from
smlng,
leandrolanzieri,
aabadie,
MichelRottleuthner and
fjmolinas
as code owners
maribu
commented
Jun 10, 2022
Fix incorrect printing of the separator after the last item.
Add also a test for correct behavior of `print()` when the string doesn't happen to be zero-terminated at the expected position.
benpicco
added
CI: ready for build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
As the title says (hopefully...). It works at least with
riot/riotbuild, but it also did so before...I also sneaked in a fix for
ipv6_addrs_print()that is unrelated, but equally trivial.Testing procedure
E.g.
examples/telnet_servershould now print the IPv6 address.Issues/PRs references
Alternative to #18183