boards/esp32: cleanup CI compilation for esp_wifi_enterprise #18218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the board definition of `esp32_wrover_kit` default values for `ESP_WIFI_EAP_USER` and `ESP_WIFI_EAP_PASS` had to be defined because this board was used in the CI to compile the optional module `esp_wifi_enterprise`. Now that the CI compilation for the `esp_wifi_enterprise` module is realized by an external board definition `esp32-ci`, these default values should be removed to make the compilation fail if the user did not define these variables.
`ESP_WIFI_EAP_USER` and `ESP_WIFI_EAP_PASS` have to be defined because this board is used in the CI to compile the optional module `esp_wifi_enterprise`.
gschorcht
requested review from
smlng,
leandrolanzieri,
aabadie,
MichelRottleuthner and
fjmolinas
as code owners
github-actions
bot
added
Area: boards
gschorcht
added
Type: cleanup
gschorcht
force-pushed
the
boards/esp32/cleanup_ci_compilation
branch
from
81bdd9d to
3414629
Compare
benpicco
approved these changes
Jun 16, 2022
gschorcht
force-pushed
the
boards/esp32/cleanup_ci_compilation
branch
from
c988816 to
3414629
Compare
|
@benpicco Thanks for reviewing and merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR is a cleanup of the CI compilation of optional ESP module
esp_wifi_enterprise.In the board definition of
esp32_wrover_kit, default values forESP_WIFI_EAP_USERandESP_WIFI_EAP_PASShad to be defined because this board was used in the CI to compile the optional moduleesp_wifi_enterprise(PR #17314).Now where the CI compilation for the
esp_wifi_enterprisemodule is realized by an external board definitionesp32-ci, these default values should be removed fromesp32_wrover_kitto let the compilation fail if the user did not define these required variables. Instead, the variables are defined for the CI compilation inMakefile.includeof external board definitionesp32-ci.Testing procedure
USEMODULE=esp_wifi_enterprise BOARD=esp32-wrover-kit make -j8 -C examples/gnrc_minimalshould fail.Issues/PRs references
Cleanup of PR #17314