-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cpu/esp_common: FreeRTOS adaptation layer changes/extension required for ESP-IDF HAL/LL #18224
cpu/esp_common: FreeRTOS adaptation layer changes/extension required for ESP-IDF HAL/LL #18224
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, I think this is pretty much alright.
I've been pretty busy the last couple of weeks, so had little time to review this. I hope this will get better soon.
cpu/esp_common/Makefile.dep
Outdated
ifneq (,$(filter ztimer_msec,$(USEMODULE))) | ||
USEMODULE += core_thread_flags | ||
endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ifneq (,$(filter ztimer_msec,$(USEMODULE))) | |
USEMODULE += core_thread_flags | |
endif | |
ifneq (,$(filter esp_freertos_common,$(USEMODULE))) | |
ifneq (,$(filter ztimer_msec,$(USEMODULE))) | |
USEMODULE += core_thread_flags | |
endif | |
endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you suggest it for better documentation? esp_freertos_common
is always used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still hope we can make it a standalone module one day, so then this would not be forgotten but just copied over.
Just squash directly - if there are no regressions this should be good to merge. |
98a3196
to
a15e01e
Compare
The mutex and semaphor handling had to be extended by the thread pid.
a15e01e
to
c8d8e5d
Compare
@benpicco Thanks for reviewing and merging. |
Contribution description
As discussed in PR #17841, this PR is a split out of the changes and extensions that are required to use the ESP-IDF HAL or LL. It includes:
xQueueReset
xSemaphoreGetMutexHolder
pcTaskGetTaskName
anduxTaskGetStackHighWaterMark
pvTaskGetThreadLocalStoragePointer
andvTaskSetThreadLocalStoragePointerAndDelCallback
xTaskNotify
andxTaskNotifyWait
xQueue*
functionsxRingbbuffer*
Testing procedure
Without using the ESP-IDF as provided by PR #17841, the only test is green CI.
Issues/PRs references
Split out of PR #17841