Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpu/esp32: use ESP-IDF dac HAL for periph/dac #18272

Closed
wants to merge 2 commits into from
Closed

cpu/esp32: use ESP-IDF dac HAL for periph/dac #18272

wants to merge 2 commits into from

Conversation

gschorcht
Copy link
Contributor

Contribution description

This PR is a split-off from PR #17841 and provides:

  • the ESP-IDF dac interface API for RIOT
  • the changes to use the ESP-IDF dac HAL

This PR depends on PR #18271.

Testing procedure

Compile and test with

BOARD=esp32-wroom-32 make -j8 -C tests/periph_dac flash term

Issues/PRs references

Split-off from PR #17841
Depends on PR #18271

@gschorcht gschorcht requested a review from benpicco June 28, 2022 14:03
@github-actions github-actions bot added Area: cpu Area: CPU/MCU ports Platform: ESP Platform: This PR/issue effects ESP-based platforms labels Jun 28, 2022
@gschorcht gschorcht added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation State: waiting for other PR State: The PR requires another PR to be merged first labels Jun 28, 2022
@gschorcht gschorcht changed the title cpu/esp32: use ESP-IDF dac HAL cpu/esp32: use ESP-IDF dac HAL for periph/dac Jun 28, 2022
@gschorcht gschorcht mentioned this pull request Jul 13, 2022
Merged
@gschorcht
Copy link
Contributor Author

Since the changes to periph/adc are not possible independently of periph/dac, the changes of this PR had to be provided by PR #18271. This PR is therefore closed in favor of PR #18271.

@gschorcht gschorcht closed this Jul 16, 2022
@gschorcht gschorcht mentioned this pull request Jul 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco Awaiting requested review from benpicco

Assignees
No one assigned
Labels
Area: cpu Area: CPU/MCU ports Platform: ESP Platform: This PR/issue effects ESP-based platforms State: waiting for other PR State: The PR requires another PR to be merged first Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gschorcht