cpu/esp32: make esp_hw_counter feature dependent on ESP32x SoC family #18317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Area: cpu
benpicco
reviewed
Jul 18, 2022
Feature esp_hw_counter is not supported by all ESP32x SoC variants (families). Therefore it has to be defined dependent on defined CPU_FAM.
gschorcht
added
the
CI: ready for build
gschorcht
force-pushed
the
cpu/esp32/esp_hw_counter_feature_change
branch
from
8272b10 to
b5ea942
Compare
gschorcht
added
the
Type: cleanup
gschorcht
requested review from
leandrolanzieri,
jia200x and
MrKevinWeiss
as code owners
benpicco
approved these changes
Jul 18, 2022
|
@benpicco Thanks for reviewing and merging it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Feature
esp_hw_counteris not supported by all ESP32x SoC variants (families). Therefore, it has to be defined dependent onCPU_FAM.This PR is a split-off from PR #17842.
Testing procedure
Green CI
Issues/PRs references
Split-off from PR #17842