makefiles/suit: avoid unwanted key creation trigger #18344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a trigger of re-creation of an already existing SUIT key when combining a build target with the clean target, e.g. `make clean all`.
benpicco
added
Type: bug
benpicco
approved these changes
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This fixes a trigger of re-creation of an already existing SUIT
key when combining a build target with the clean target, e.g.
make clean all.Testing procedure
Without the changes of this PR
make -jin${RIOTBASE}/examples/suit_updatewill build & conditionally create a key in${RIOTBASE}/keys/default.pemif none is there.Running
make cleanwill leave the key in place.Re-running
make -jwill reuse the existing key.Running
make -j clean allwill try to re-create a key in the location although it exists. The process will fail because the key generator checks for an existing key. However, it should not even be executed.With the changes of this PR
Making the dependency on
CLEANorder-only will avoid attempting to re-create a key when there is already one.make -j clean alldoes not touch an existing key runs the clean build without error.Issues/PRs references
None.