-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gnrc_netif_conf: fix auto-6ctx switch #18370
Conversation
I think the test proceeding is missing a BOARD=native RIOT_CONFIG_GNRC_NETIF_IPV6_BR_AUTO_6CTX=n RIOT_CONFIG_KCONFIG_USEMODULE_GNRC_NETIF=y SHOULD_RUN_KCONFIG=1 make -C examples/gnrc_border_router -j I tested by adding a check in #if IS_ACTIVE(CONFIG_GNRC_NETIF_IPV6_BR_AUTO_6CTX)
#error "Compression context"
#else
#error "No compression context"
#endif With this PR the option is not overwritten by the header file when configuring with Kconfig. |
IIRC with the |
The example is explicitly disabling it RIOT/examples/gnrc_border_router/Makefile Lines 112 to 114 in 9e283b9
|
Backport provided in #18375 |
Contribution description
When configuring a boolean via Kconfig and setting it to
n
, the result is that the symbol will not be defined as a preprocessor macro. As a result, settingCONFIG_GNRC_NETIF_IPV6_BR_AUTO_6CTX
ton
has no effect, as(as was pointed out in #17678 (comment)). Without changing the name to a negative, the only other valid option is to check if
gnrc_netif
was configured via Kconfig in addition to the normal#ifndef
. This PR applies that change.Testing procedure
Once a global address is configured with
the table returned by
6ctx
should remain empty.Issues/PRs references
Follow-up on #17678