cpu/esp32: fix provided features and Kconfig for esp_eth #18394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In fact the ESP32 has no peripheral driver for the ETH interface. Instead, the `esp_eth` netdev driver directly uses the ESP-IDF Ethernet API. This caused compilation problems with Kconfig. Therefore the required feature `periph_eth` is replaced by the feature `esp_eth`.
gschorcht
requested review from
leandrolanzieri,
jia200x,
MrKevinWeiss,
smlng,
aabadie,
MichelRottleuthner,
fjmolinas and
kaspar030
as code owners
github-actions
bot
added
Area: boards
gschorcht
added
Type: bug
In fact the ESP32 has no peripheral driver for the ETH interface. Instead, the `esp_eth` netdev driver directly uses the ESP-IDF Ethernet API. This caused compilation problems with Kconfig. Therefore the required feature `periph_eth` is replaced by the feature `esp_eth`.
gschorcht
force-pushed
the
cpu/esp32/fix_kconfig_for_esp_eth
branch
from
3ad2d58 to
2347e80
Compare
MrKevinWeiss
added
CI: ready for build
MrKevinWeiss
approved these changes
Aug 3, 2022
|
@MrKevinWeiss Thanks for reviewing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR fixes Kconfig problems for
esp_ethintroduced with PR #17739.In
Makefiles.features,periph_ethwas defined as provided feature without having a peripheral driver implementation for the ETH interface incpu/esp32/periph. Instead, theesp_ethnetdev driver directly uses the ESP-IDF Ethernet API. This caused compilation problems with Kconfig. Therefore the required featureperiph_ethis replaced by the featureesp_ethandHAS_PERIPH_ETHis replaced byHAS_ESP_ETHin Kconfig.Furthermore, the selection of modules in Kconfig was not correct if the module
esp_ethwas used. The reason for this is that the dependencies of modules have changed with the migration to ESP-IDF 4.4.Since no board with the feature
esp_ethwas compiled withTEST_KCONFIG=1, the problems were not detected by the CI compilation and was only found when investigating the reasons for the failure of the nightly builds. Therefore,esp32-olimex-evbin.murdockis set toTEST_KCONFIG_BOARDS_AVAILABLE.Testing procedure
Use command
to compile. Wihtout this PR, the compilation fails.
Issues/PRs references